Bug 479966 (CVE-2008-5824)

Summary: CVE-2008-5824 audiofile: heap-based overflow in Microsoft ADPCM compression module (app crash, arb. code execution)
Product: [Other] Security Response Reporter: Jan Lieskovsky <jlieskov>
Component: vulnerabilityAssignee: Red Hat Product Security <security-response-team>
Status: CLOSED WONTFIX QA Contact:
Severity: low Docs Contact:
Priority: low    
Version: unspecifiedCC: bnocera, jrusnack, michael
Target Milestone: ---Keywords: Security
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=510205
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-02-17 15:34:22 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 483239, 483240, 483241, 665500    
Bug Blocks:    
Attachments:
Description Flags
22_CVE-2008-5824.dpatch by Stefan Fritsch
none
Local copy of normalize.diff by Stefan Fritsch none

Description Jan Lieskovsky 2009-01-14 10:28:08 UTC
Common Vulnerabilities and Exposures assigned an identifier CVE-2008-5824 to
the following vulnerability:

Heap-based buffer overflow in msadpcm.c in libaudiofile in audiofile
0.2.6 allows context-dependent attackers to cause a denial of service
(application crash) or possibly execute arbitrary code via a crafted
WAV file.

References:
http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2008-5824
http://openwall.com/lists/oss-security/2008/12/30/1
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=510205
http://musicpd.org/mantis/view.php?id=1915

PoC:
http://filebin.ca/meqmyu/max_theme.wav

Note: The Debian patch at:
http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=17;filename=audiofile-msadpcm-fix.diff;att=1;bug=510205
is only partial (doesn't protect against buffer overflows).

Comment 1 Jan Lieskovsky 2009-01-14 10:29:44 UTC
This issue does NOT affect the version of the audiofile package, as shipped
with Red Hat Enterprise Linux 2.1.

This issue affects the versions of the audiofile package, as shipped
with Red Hat Enterprise Linux 3, 4, and 5.

This issue affects the versions of the audiofile package, as shipped
with Fedora release of 9, 10 and devel.

Please fix.

Comment 3 Jan Lieskovsky 2009-01-15 12:53:19 UTC
The Red Hat Security Response Team has rated this issue as having low security
impact, a future update may address this flaw.  More information regarding
issue severity can be found here:
http://www.redhat.com/security/updates/classification/

Comment 7 Jan Lieskovsky 2009-11-30 19:00:21 UTC
Stefan Fritsch provided updated patches to the Debian bug. These are
available here:

  http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=59;filename=22_CVE-2008-5824.dpatch;att=1;bug=558399

and:

  http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=76;filename=normalize.diff;att=1;bug=558399

(Will attach them as local copies too).

Comment 8 Jan Lieskovsky 2009-11-30 19:01:20 UTC
Created attachment 374844 [details]
22_CVE-2008-5824.dpatch by Stefan Fritsch

Comment 9 Jan Lieskovsky 2009-11-30 19:03:35 UTC
Created attachment 374846 [details]
Local copy of normalize.diff by Stefan Fritsch

Comment 10 Vincent Danen 2010-12-24 04:02:25 UTC
I don't believe this was ever fixed, and I don't know if it was corrected in upstream 0.2.7 (judging by the changelog on their site it doesn't look like it).  I have not looked at any code to determine if this is the case.

Comment 11 Vincent Danen 2010-12-24 04:02:52 UTC
Created audiofile tracking bugs for this issue

Affects: fedora-all [bug 665500]

Comment 12 Michael Pruett 2012-10-10 18:04:20 UTC
This CVE was fixed by commit e8cf0095b3f319739f9aa1ab5a1aa52b76be8cdd:

https://github.com/mpruett/audiofile/commit/e8cf0095b3f319739f9aa1ab5a1aa52b76be8cdd

Audio File Library version 0.2.7, published on 21 March 2010, was the first release to include this commit. This fix is present in subsequent versions of the library including the current release, version 0.3.4.

Comment 13 Vincent Danen 2015-02-17 15:34:22 UTC
Statement:

Red Hat Product Security has rated this issue as having Low security impact. This issue is not currently planned to be addressed in future updates. For additional information, refer to the Issue Severity Classification: https://access.redhat.com/security/updates/classification/.