Bug 480102

I'm actually using Weka right now, so I'll take the review. Will post review notes in a bit.

General guidelines:

MUST

+ rpmlint
+ package name
+ spec file name
+ package guideline-compliant
+ license complies with guidelines
+ license field accurate
+ license file not deleted
+ spec in US English
+ spec legible
+ source matches upstream
+ builds under >= 1 archs, others excluded
  noarch
+ build dependencies complete
N/A locales handled using %find_lang, no %{_datadir}/locale
+ own all directories
+ no dupes in %files
+ permission
+ %clean RPM_BUILD_ROOT
+ macros used consistently
+ Package contains code
+ large docs => -doc (-javadoc)
+ doc not runtime dependent

- desktop file uses desktop-file-install

  Desktop file uses desktop-file-install, but the path to the icon is wrong:
  /usr/share/icons/weka.ico rather than just
  1. weka (which is preferable) or 
  2. the correct path (/usr/share/icons/hicolor/yadda yadda)

  It looks like .ico files are not automatically picked up by GNOME's menu,
  so I'd consider converting the icon to .png (it makes it smaller as well),
  in which case you can just refer to it as Icon=weka. Otherwise, you'd have
  to use the complete path

  Also, icon caches are not updated:
  http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GTK.2B_icon_cache


+ clean buildroot before install
• filenames UTF-8

SHOULD
+ package build in mock on all architectures
+ package functioned as described
+ scriplets are sane
+ other subpackages should require versioned base
+ require package not files

Java-specific:
http://fedoraproject.org/wiki/Packaging/Java

- Java requirement must be versioned (see BuildRequires and Requires)

Otherwise, it looks fine, so I can approve this after the fixes are made.

* Wed Feb 27 2009 Milos Jakubicek <xjakub.cz> - 3.6.0-2
- Running gtk-update-icon-cache
- Converting icon to png, added BR:ImageMagick, changed icon path
  in desktop file "weka" only
- java/java-devel R: and BR: made versioned to >= 1:1.6.0
- removed vendor tag in desktop-file-install according to the guidelines
  for new packages.

New SRPM: http://mjakubicek.fedorapeople.org/weka/weka.spec
New SPEC: http://mjakubicek.fedorapeople.org/weka/weka-3.6.0-2.fc10.src.rpm

Most of the changes are fine. Would be a good idea to turn on the test suite, between %build and %install:

%check
CLASSPATH=/usr/share/java/junit4.jar ant run_tests

This currently fails, though:
run_tests:
    [junit] Error: java.lang.ClassCastException: class weka.AllTests

not sure why, you might want to ask on the upstream mailing list.

Oh, and the %files section needs to be updated: it's still refering to fedora-%{name}.desktop.

(In reply to comment #4)
> Most of the changes are fine. Would be a good idea to turn on the test suite,
> between %build and %install:
> 
> %check
> CLASSPATH=/usr/share/java/junit4.jar ant run_tests
> 
Of course, that should have been

BuildRequires: junit

%check
CLASSPATH=/usr/share/java/junit.jar ant run_tests

It takes forever to run, though, so perhaps surround it in an %if?

%if %{?_with_tests:1}%{!?_with_tests:0}
%check
...
%endif

(and put a one-line comment at the top describing the --with tests option)

But that's secondary -- apart from the desktop file naming, this is good to go.

* Sat Feb 28 2009 Milos Jakubicek <xjakub.cz> - 3.6.0-3
- Fixed desktop file name
- Added optional running junit tests into %%check, added BR:junit
- Fixed changelog entry

The failing jUnit tests have been files into upstream bugtracker.

New SRPM: http://mjakubicek.fedorapeople.org/weka/weka.spec
New SPEC: http://mjakubicek.fedorapeople.org/weka/weka-3.6.0-3.fc10.src.rpm

Changes look good.

APPROVED

Michel, thanks for review!

New Package CVS Request
=======================
Package Name: weka
Short Description: Waikato Environment for Knowledge Analysis
Owners: mjakubicek
Branches: F-9 F-10
InitialCC:

cvs done.

weka-3.6.0-3.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/weka-3.6.0-3.fc9

weka-3.6.0-3.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/weka-3.6.0-3.fc10

weka-3.6.0-3.fc10 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update weka'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-2276

weka-3.6.0-3.fc9 has been pushed to the Fedora 9 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing-newkey update weka'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-2299

weka-3.6.0-3.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

weka-3.6.0-3.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.