Bug 480222
| Summary: | Review Request: nullmodem - A utility to loopback pseudo-terminals | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> |
| Component: | Package Review | Assignee: | Lucian Langa <lucilanga> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, lucilanga, notting |
| Target Milestone: | --- | Flags: | lucilanga:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-02-20 11:56:37 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Fabian Affolter
2009-01-15 19:03:46 UTC
Review:
OK source files match upstream:
7ccb4c831f9a33c14f6c6e599e1ac102 nullmodem-0.0.5.tar.gz
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK summary is OK.
OK description is OK.
OK dist tag is present.
OK build root is OK.
NOT OK license field matches the actual license.
OK license is open source-compatible.
OK license text included in package.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (rawhide, x86_64).
OK package installs properly.
OK debuginfo package looks complete.
OK rpmlint is silent.
final provides and requires are sane:
nullmodem = 0.0.5-1.fc11
nullmodem(x86-64) = 0.0.5-1.fc11
=
libc.so.6()(64bit)
libgcc_s.so.1()(64bit)
libm.so.6()(64bit)
libstdc++.so.6()(64bit)
libutil.so.1()(64bit)
OK %check is not present; no test suite upstream.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK code, not content.
OK documentation is small, so no -doc subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no static libraries.
OK no libtool .la files.
License tag should be GPL+
COPYING says GPLv2, source header not specified, index.html says GPL. Paragraph 9 of COPYING: "If the Program does not specify a version number of this License, you may choose any version ever published by the Free Software Foundation." http://fedoraproject.org/wiki/Licensing says: "A GPL or LGPL licensed package that lacks any statement of what version that it's licensed under in the source code/program output/accompanying docs is technically licensed under *any* version of the GPL or LGPL, not just the version in whatever COPYING file they include." License tag changed. Updated files: Spec URL: http://fab.fedorapeople.org/packages/SRPMS/nullmodem.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/nullmodem-0.0.5-2.fc9.src.rpm Looking good. APPROVED. Lucian, thanks for the review. New Package CVS Request ======================= Package Name: nullmodem Short Description: A utility to loopback pseudo-terminals Owners: fab Branches: F-9 F-10 InitialCC: cvs done. nullmodem-0.0.5-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update nullmodem'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-1355 nullmodem-0.0.5-2.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update nullmodem'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-1371 |