Bug 480249
| Summary: | Review Request: unalz - Decompression utility | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Orcan Ogetbil <oget.fedora> |
| Component: | Package Review | Assignee: | Lucian Langa <lucilanga> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, lucilanga, notting, tcallawa |
| Target Milestone: | --- | Flags: | lucilanga:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.64-1.fc10 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-03-09 22:46:48 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Orcan Ogetbil
2009-01-15 22:05:56 UTC
Version update: Spec URL: http://oget.fedorapeople.org/review/unalz.spec SRPM URL: http://oget.fedorapeople.org/review/unalz-0.64-1.fc10.src.rpm It looks like the author put the license information on more source file headers. ALZ is either a hacked up bzip2 or DEFLATE, depending on the version of ALZip used to create the file. There are no patent concerns here. Lifting FE-Legal. This is a simple package; it builds fine and rpmlint is silent.
Review:
OK source files match upstream:
974ff01225273f1ef70c5f1a2d27d25b219bc43719f90ea80e550feaab46876f unalz-0.64.tgz
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK summary a short and concise description.
OK description is OK.
Ok dist tag is present.
OK build root is sane.
OK license field matches the actual license.
OK license is open source-compatible.
OK license text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (rawhide, x86_64).
OK package installs properly.
OK debuginfo package looks complete.
OK rpmlint is silent.
OK final provides and requires are sane:
unalz = 0.64-1.fc11
unalz(x86-64) = 0.64-1.fc11
=
libc.so.6()(64bit)
libgcc_s.so.1()(64bit)
libm.so.6()(64bit)
libstdc++.so.6()(64bit)
libz.so.1()(64bit)
OK %check is not present; no test suite upstream
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
APPROVED.
Thank you for the review. New Package CVS Request ======================= Package Name: unalz Short Description: Decompression utility Owners: oget Branches: F-9 F-10 InitialCC: cvs done. unalz-0.64-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. unalz-0.64-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |