Bug 480254
| Summary: | Review Request: deletemail - A non-interactive tool for deleting mails | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.5-1.fc10 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-03-04 16:25:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Fabian Affolter
2009-01-16 00:05:20 UTC
This is tiny and it might be useful, so I'll take a look. COPYING does indeed contain an MIT license, and many of the source files do as well, but a couple (strcasestr.c, strncasecmp.c) carry the BSD license. However, it doesn't seem as though those two source files are used when building on Linux, and so the resulting package I believe still has the MIT license as you have indicated, so that's OK. Honestly I don't see anything else to comment on. * source files match upstream. sha256sum: 25600727a3fba9eb4e97762e0f675a2fb82e6eec454d74761525fd8c11fe8468 deletemail-0.5.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: deletemail = 0.5-1.fc11 deletemail(x86-64) = 0.5-1.fc11 = libcrypto.so.8()(64bit) libssl.so.8()(64bit) * I tested the package and it seems to work as advertised. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. APPROVED The package review process needs reviewers! If you haven't done any package reviews recently, please consider doing one. New Package CVS Request ======================= Package Name: deletemail Short Description: A non-interactive tool for deleting mails Owners: fab Branches: F-9 F-10 InitialCC: cvs done. Pushed to testing https://admin.fedoraproject.org/updates/F9/FEDORA-2009-1549 https://admin.fedoraproject.org/updates/F10/FEDORA-2009-1578 deletemail-0.5-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. deletemail-0.5-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |