Bug 480567

Summary:	Review Request: dnssec-conf - DNSSEC and DLV configuration and priming tool
Product:	[Fedora] Fedora	Reporter:	Paul Wouters <pwouters>
Component:	Package Review	Assignee:	Jochen Schmitt <jochen>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	atkac, fedora-package-review, jochen, notting, pwouters
Target Milestone:	---	Flags:	jochen: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-03-03 18:51:04 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Paul Wouters 2009-01-19 02:16:38 UTC

Spec URL: ftp://ftp.xelerance.com/dnssec-conf/dnssec-conf.spec
SRPM URL: ftp://ftp.xelerance.com/dnssec-conf/dnssec-conf-1.10-1.src.rpm
Description: DNSSEC configuration and priming tool. Keys are required until
the root is signed, as well as for local unpublished DNSSEC keys to be preloaded
into the recursive nameserver. These DNSSEC configuration files can be
directly included in the bind or unbound nameserver configuration files.
dnssec-conf includes a commandline configuration client for Bind and
Unbound, known DNSSEC keys, URL's to official publication pages of keys,
and harvested keys, as well a script to harvest DNSKEY's from DNS.
See also: system-config-dnssec (filed seperately for package review)

Comment 1 Jochen Schmitt 2009-01-19 19:54:51 UTC

God:
+ Basename of the SPEC files matches with package name
+ Name of the package fits naming guidelines
+ Package contains most recent release
+ Package contains valid License tag
+ License tag contains GPLv2+ as a valid OSS license
+ License review on source files state, that GPLv2 may be
+ Package contains a verbatin copy of the license text
+ Package has no subpackages
+ Local buidl works fine
+ Package contains %clean stanza
+ Buildroot will be deleted on the beginning of %clean and %install
+ Local install works fine
+ Local uninstall works fine
+ Start of dnssec-conf without argument works witoht crash
+ Build on koji works fine
+ Rpmlint has no complaints about the source package
+ Rpmlint has no complaints about the binary package
+ Files has proper file permissions
+ All packaged files belong to the package
+ Package contains no files belong to other packages
+ %doc subpackage has a small amont, so we need no separate doc subpackage
+ Package contains proper %changelog

Bad.
- source tag not fully quallified
- Package use $RPM_BUILD_ROOT and %{buildroot}
- License review on source files state, that GPLv2 may be
right value for the license tag

TODO:
- Please notify upstream, that eatch source file should have
a proper copyright notice

Comment 2 Paul Wouters 2009-01-21 14:38:31 UTC

Fixed all issues (bad and TODO)

Spec URL: ftp://ftp.xelerance.com/dnssec-conf/dnssec-conf.spec
SRPM URL: ftp://ftp.xelerance.com/dnssec-conf/dnssec-conf-1.13-1.src.rpm

Thanks for the review!

Comment 3 Jochen Schmitt 2009-01-21 17:41:10 UTC

Bad:
- The current upstream release is 1.12.
- License tag was not changed from GPLv2+ to GPLv2
I couldN't download 1.13 via spectool -g
- Please write $$RPM_BUILD_ROOT and %%{buildroot} in the %changelog stanza for excaping the special chars '$' and '%'

Comment 4 Paul Wouters 2009-01-22 04:34:55 UTC

- Upstream was at 1.13, but upstream misplaced the file and fixed it :=)
- Upstream license is GPLv2+, not GPLv2
- spectool -g now properly downloads 1.13
- fixed macros in changelog

Spec URL: ftp://ftp.xelerance.com/dnssec-conf/dnssec-conf.spec
SRPM URL: ftp://ftp.xelerance.com/dnssec-conf/dnssec-conf-1.13-2.src.rpm

Comment 5 Jochen Schmitt 2009-01-22 17:17:38 UTC

Good:
+ Could downloaded upstream tar ball via spectool -g
+ Packaged tar ball matches with upstream one.
(md5sum: c998c8050c77c14eda496b26891bb4c1)
+ License GPLv2+ is matches with the copyright notice in the course file
+ Local build works fine
+ Build on koji works fine.

TDDO:
+ You need on add a extran '%' to escape the specila '%' char in the %changelog stanza. Escaping the '$' character is no necessary in the %changelog stanza, so you can write

* Wed Jan 21 2009 Paul Wouters <paul> - 1.13-1
- Clarify license
- Fix mixed use of $RPM_BUILD_ROOT and %%{buildroot}
- Source tag fully qualified now

*** APPROVED ***

Comment 6 Paul Wouters 2009-01-23 15:37:27 UTC

New Package CVS Request
=======================
Package Name: dnssec-conf
Short Description: DNSSEC and DLV configuration and priming tool
Owners: pwouters
Branches: F-10, F-9, EL-5
InitialCC:

Comment 7 Kevin Fenzi 2009-01-23 23:20:30 UTC

cvs done.

Comment 8 Jochen Schmitt 2009-03-03 17:26:26 UTC

Please close this bug after you have push your package on bodhi