Bug 480591
| Summary: | Review Request: ctan-kerkis-fonts - Kerkis type 1 fonts | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sarantis Paskalis <paskalis> |
| Component: | Package Review | Assignee: | Sarantis Paskalis <paskalis> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | alex, fedora-package-review, mfabian, notting |
| Target Milestone: | --- | Flags: | nicolas.mailhot:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-01-25 15:16:52 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 477462 | ||
|
Description
Sarantis Paskalis
2009-01-19 11:13:53 UTC
will work on it this evening (CET) 1. needs _texmf_main defined like cm-lgc 2. rpmlint complains of mixed-use-of-spaces-and-tabs 3. kerkis calligraphic and the small caps variants clearly needs their own subpackage. Please make sure you only group in the same font subpackage fonts of the same family (differing only in weight, width or slant). I didn't check the others 4. the main package does not need to Requires: fontpackages-filesystem 5. It's probably a good idea to add fontconfig substitution rules for the URW fonts kerkis is derived of, assuming the Kerkis creators didn't change the design and metrics too much (cf the substitution template in filepackages-devel) 6. please try to get you fontconfig files merged in upstream kerkis once you're happy with them 7. please add your new fonts subpackages to comps http://fedoraproject.org/wiki/Comps_fonts_rules 8. you obsoletes should be Obsoletes: tetex-font-kerkis < 2.0-17 to provide an upgrade path to the F10 kerkis package, so this version does not pass rename review (In reply to comment #2) > 1. needs _texmf_main defined like cm-lgc Fixed. > 2. rpmlint complains of mixed-use-of-spaces-and-tabs Fixed (probably, local rpmlint does not complain, I could not see where tab was) > 3. kerkis calligraphic and the small caps variants clearly needs their own > subpackage. Please make sure you only group in the same font subpackage fonts > of the same family (differing only in weight, width or slant). I didn't check > the others OK with the Calligraphic family. The SmallCaps files however define the font family to be "Kerkis", and not "Kerkis-SmallCaps" or something like that. I put it therefore in the -serif subpackage. The other font files that differentiate themselves are the SemiBold variants, that define a family of "Kerkis-SemiBold". This however is just another weight (like Bold) as described by the font's authors (http://www.tug.org/TUGboat/Articles/tb23-3-4/tb75tsol.pdf), so I placed it in the -serif-fonts subpackage > 4. the main package does not need to > Requires: fontpackages-filesystem Fixed. > 5. It's probably a good idea to add fontconfig substitution rules for the URW > fonts kerkis is derived of, assuming the Kerkis creators didn't change the > design and metrics too much (cf the substitution template in > filepackages-devel) Added some substitution rules for the font family names as displayed in Gnome Character Map. > 6. please try to get you fontconfig files merged in upstream kerkis once you're > happy with them It's kind of dead upstream, and considering that the primary force to create the font was the usage in LaTeX, I don't think I will be very successful. I will try though. > 7. please add your new fonts subpackages to comps > http://fedoraproject.org/wiki/Comps_fonts_rules Will do as soon as there are rawhide rpms. > 8. you obsoletes should be > Obsoletes: tetex-font-kerkis < 2.0-17 > to provide an upgrade path to the F10 kerkis package, so this version does not > pass rename review Fixed. New spec and srpm in the same location http://gallagher.di.uoa.gr/any/rpms/ctan-kerkis-fonts/ (In reply to comment #3) > (In reply to comment #2) > > 3. kerkis calligraphic and the small caps variants clearly needs their own > > subpackage. Please make sure you only group in the same font subpackage fonts > > of the same family (differing only in weight, width or slant). I didn't check > > the others > > OK with the Calligraphic family. > > The SmallCaps files however define the font family to be "Kerkis", and not > "Kerkis-SmallCaps" or something like that. I put it therefore in the -serif > subpackage. Ok. However please note that both the w3c (in CSS) and Microsoft (in its whitepaper to new fonts authors) only define weight, width or slant as selection axis for font faces within a font family. So if the font files were created today, small caps would be a different font family. > It's kind of dead upstream, and considering that the primary force to create > the font was the usage in LaTeX, I don't think I will be very successful. I > will try though. xetex uses fontconfig IIRC > New spec and srpm in the same location > http://gallagher.di.uoa.gr/any/rpms/ctan-kerkis-fonts/ ❉❉❉ APPROVED ❉❉❉ Nicolas, I think you wanted to set the fedora-review+ flag instead of fedora-cvs+ Anyway, Package Change Request ====================== Package Name: ctan-kerkis-fonts New Branches: devel Owners: sarantis This is a rename request of tetex-font-kerkis for the devel branch only. Nicolas: Can you set this fedora-review: + if you approve it? (In reply to comment #6) > Nicolas: Can you set this fedora-review: + if you approve it? Sorry, my bad cvs done. Don't forget to follow the end of life procedure for the old procedure. Built in rawhide. Added in comps. EOL for tetex-font-kerkis done. |