Bug 480646
| Summary: | Review Request: urlwatch - A tool for monitoring webpages for updates | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> |
| Component: | Package Review | Assignee: | Jochen Schmitt <jochen> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | cassmodiah, fedora-package-review, itamar, jochen, notting |
| Target Milestone: | --- | Flags: | jochen:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-02-20 11:57:57 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Fabian Affolter
2009-01-19 16:57:50 UTC
God: + Basename of SPEC file matches with package name + Package name fits with maming guidelines + Consistently usage of rpm macros + Package contains no subpackages + Source tar ball could downloaed via spectool + Tar ball in package matches with upstream (md5sum: 29b3a00caad5f45c905ec621bec26687) + Package contains valid License tag + License tag has MIT as an valid OSS license + Package contains verbatin copy of the license text + Buildroot will be clean on the beginning of %install and %clean + Package has a %clean stanza + Local buidl works fine. + Local install works fine + Simple call to urlwatch works without crash + Local uninstall works fine + Build on koji works fine + Package will be build as noarch + Rpmlint has no complaints for source rpm + Rpmlint has no complaints for binary rpm + Files has proper file permissions + All packaged files are owned by the package + No packaged files are claimed by other packages + %doc stanza has small amount of files, so we need no separate doc subpackage *** APPROVED *** the license stated in urlwatch website is another. http://thpinfo.com/2008/urlwatch/ "License urlwatch is released under the terms of the BSD license" why MIT in spec file ? Itamar, you are right the license seems more to match the 'New BSD (no advertising, 3 clause)' than MIT. I will change the license tag to BSD before cvs import. New Package CVS Request ======================= Package Name: urlwatch Short Description: A tool for monitoring webpages for updates Owners: fab Branches: F-9 F-10 InitialCC: cvs done. urlwatch-1.7-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/urlwatch-1.7-2.fc10 urlwatch-1.7-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/urlwatch-1.7-2.fc9 Thanks for the review and the cvs. urlwatch-1.7-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update urlwatch'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-0729 urlwatch-1.7-2.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update urlwatch'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-0731 Was pushed to stable https://admin.fedoraproject.org/updates/F10/FEDORA-2009-0729 https://admin.fedoraproject.org/updates/F9/FEDORA-2009-0731 *** Bug 493299 has been marked as a duplicate of this bug. *** |