Bug 480754
Summary: | Review Request: udev-extras - extra rules and tools for udev | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Harald Hoyer <harald> |
Component: | Package Review | Assignee: | Matthias Clasen <mclasen> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, kay.sievers, mclasen, notting |
Target Milestone: | --- | Flags: | mclasen:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-01-29 23:05:52 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Harald Hoyer
2009-01-20 11:02:09 UTC
Misses some build deps: BuildRequires: glib2-devel BuildRequires: libusb-devel BuildRequires: libxslt Adding those three makes the build succeed in mock rpmlint says: udev-extras.i386: E: zero-length /usr/share/doc/udev-extras-20081230/ChangeLog udev-extras.i386: E: zero-length /usr/share/doc/udev-extras-20081230/README udev-extras.i386: W: incoherent-version-in-changelog 20081230-0.git20090120.1 ['20081230-0.1.20090120git.fc11', '20081230-0.1.20090120git'] 3 packages and 0 specfiles checked; 2 errors, 1 warnings. So I guess you want to remove those 0 length files package name: ok spec file name: ok packaging guidelines: ok license: ok license field: from a brief look, it appears that probe-modem is GPLv2, while the rest is GPLv2+. Might just be an oversight, worth checking with dcbw. If it is not, the license field needs to reflect that license file: ok spec language: ok spec readable: ok upstream sources: should add a comment explaining where to get the sources buildable: ok excludearch: ok build deps: need to add glib2-devel, libusb-devel, libxslt locales: ok shared libs: n/a relocatable: n/a directory ownership: ok duplicate files: ok permissions: ok %clean: ok macro use: ok permissible content: ok large docs: ok %doc content: ok header files: n/a static libs: n/a pc files: n/a shared libs: n/a devel package: n/a la files: ok gui: n/a file ownership: ok %install: ok, though I don't see why you create sbindir if you don't install any content there ? utf8 filenames: ok summary: - fix build deps - clarify license - add source comment ok, revised Spec URL: http://harald.fedorapeople.org/downloads/udev-extras/udev-extras.spec SRPM URL: http://harald.fedorapeople.org/downloads/udev-extras/udev-extras-20081230-0.2.20090120git.fc10.src.rpm Looks fine now. Approved. New Package CVS Request ======================= Package Name: udev-extras Short Description: extra rules and tools for udev Owners: harald Branches: devel InitialCC: New Package CVS Request ======================= Package Name: udev-extras Short Description: extra rules and tools for udev Owners: harald Branches: F-10 devel InitialCC: cvs done. (In reply to comment #3) > license field: from a brief look, it appears that probe-modem is GPLv2, while > the rest is GPLv2+. Might just be an oversight, worth checking with dcbw. If > it is not, the license field needs to reflect that Checked with dcbw, changed everything to "GPLv2 or later", like the main udev. Has been built a while ago Package Change Request ====================== Package Name: udev-extras New Branches: F-9 Owners: harald cvs done. |