Bug 481159
| Summary: | Review Request: ocaml-autoconf - Autoconf macros for OCaml | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Richard W.M. Jones <rjones> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.0-4.fc11 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-05-23 06:50:48 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Richard W.M. Jones
2009-01-22 14:42:57 UTC
NOTE: setting NotReady flag on this review. We are still resolving licensing issues upstream. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1074116 This is ready for review. Spec URL: http://www.annexia.org/tmp/ocaml/ocaml-autoconf.spec SRPM URL: http://www.annexia.org/tmp/ocaml/ocaml-autoconf-1.0-1.fc10.src.rpm * Tue Mar 31 2009 Richard W.M. Jones <rjones> - 1.0-1 - Upstream has released version 1.0 and it is properly licensed. rpmlint is silent. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1268345 There's not really all that much to this package. I've no idea how to test it, of course, but packaging-wise it's fine. I would generally advise against using https links for Source URLs when the upstream sites have unverifiable certificates; it breaks spectool. Maybe one day cacert will pull its head out with regards to the licensing of its root certificates and we can include them in Fedora by default. Luckily my spectool is patched to pass --no-check-certificate. * source files match upstream. sha256sum: 67e85520f65c033c86e99e5438e51657e777579034570527c1b2c62096ecb004 ocaml-autoconf-1.0.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: ocaml-autoconf = 1.0-1.fc11 = automake * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED Somehow this bug got overlooked, sorry about that ... New Package CVS Request ======================= Package Name: ocaml-autoconf Short Description: Autoconf macros for OCaml Owners: rjones Branches: EL-5 F-10 F-11 InitialCC: cvs done. Well, I'm not sure what happened to this one - I seem to have forgotten about the package at the import stage. Anyhow, now imported and built ... F-10: http://koji.fedoraproject.org/koji/taskinfo?taskID=1371885 F-11: http://koji.fedoraproject.org/koji/taskinfo?taskID=1371887 F-12: http://koji.fedoraproject.org/koji/taskinfo?taskID=1371886 ocaml-autoconf-1.0-4.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/ocaml-autoconf-1.0-4.fc10 ocaml-autoconf-1.0-4.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/ocaml-autoconf-1.0-4.fc11 ocaml-autoconf-1.0-4.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. ocaml-autoconf-1.0-4.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |