Bug 481290
| Summary: | png2icns does not write large icons properly | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Joel Uckelman <uckelman> | ||||||||||||||||||
| Component: | libicns | Assignee: | Andrea Musuruane <musuruan> | ||||||||||||||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||||||||||||
| Severity: | high | Docs Contact: | |||||||||||||||||||
| Priority: | low | ||||||||||||||||||||
| Version: | 10 | CC: | mathew, musuruan | ||||||||||||||||||
| Target Milestone: | --- | ||||||||||||||||||||
| Target Release: | --- | ||||||||||||||||||||
| Hardware: | All | ||||||||||||||||||||
| OS: | Linux | ||||||||||||||||||||
| Whiteboard: | |||||||||||||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||||||||||||
| Doc Text: | Story Points: | --- | |||||||||||||||||||
| Clone Of: | Environment: | ||||||||||||||||||||
| Last Closed: | 2009-02-07 07:27:32 UTC | Type: | --- | ||||||||||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||||||||||
| Documentation: | --- | CRM: | |||||||||||||||||||
| Verified Versions: | Category: | --- | |||||||||||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||||||||
| Embargoed: | |||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Joel Uckelman
2009-01-23 13:10:49 UTC
Created attachment 329821 [details]
16x16 icon
Created attachment 329822 [details]
32x32 icon
Created attachment 329823 [details]
48x48 icon
Created attachment 329824 [details]
128x128 icon
Created attachment 329825 [details]
256x256 icon
Created attachment 329826 [details]
512x512 icon
Created attachment 329827 [details]
test PNGs for creating the ICNS file
I have opened an upstream bug for this: SF 2531240 https://sourceforge.net/tracker/index.php?func=detail&aid=2531240&group_id=174339&atid=868840 Hi, I am upstream author for libicns and icnsutils. Several bugs were fixed with png2icns in 0.6.1 - can you try those versions? Thank you, -Mathew Eis Hi Mathew, we ship v0.6.1 in Fedora. (In reply to comment #9) > > Several bugs were fixed with png2icns in 0.6.1 - can you try those versions? > My bug report was about 0.6.1. Okay, just wanting to double-check that you're working with 0.6.1 as it was only released recently, and several (successful) test cases were done for compatibility with OS X 10.5 at that time. Thank you for attaching the PNGs used to reproduce the problem. I currently have only limited access to machines OS X 10.5, but will try to get this taken care of within the next week or two. (In reply to comment #12) > Thank you for attaching the PNGs used to reproduce the problem. I currently > have only limited access to machines OS X 10.5, but will try to get this taken > care of within the next week or two. Thanks for looking into this. You're in a better state w/r/t testing on OS X than I am---I only have access second-hand, via one of my users who has an OS X machine. I may have a possible interim solution: Can you try creating the icon with the parameters in ascending order, i.e.: png2icns VASSAL.icns VASSAL-16.png VASSAL-32.png VASSAL-64.png VASSAL-128.png ... Please let me know if this generates a readable icon. Thank you, -Mathew Eis I built a new icon like so png2icns VASSAL.icns VASSAL-16.png VASSAL-32.png VASSAL-128.png VASSAL-256.png VASSAL-512.png and my Mac guy told me this about it: > > Would you have a look at this ICNS file in IconComposer? Do the > > large sizes show up properly for you now? > > No. They still have the black background. So, no improvement that way. I read that there were two separate problems: 1) Large icons were not showing up in the Dock 2) Backgrounds were black (i.e. alpha channel not properly encoded) The interim solutions should have had an impact on #1 - can you check that for me? Created attachment 330198 [details]
VASSAL.icns generated from patched libicns
I have made some more changes to libicns in the jp2 coding, and they appear to work in my test cases on OS X 10.5. Please have your test the attached icon, and if it looks successful, I will clean the fix up and merge it with the next release of libicns.
I am interested in knowing both the functionality of the icon in the dock, and the appearance of the clear background.
-Mathew Eis
(In reply to comment #16) > I read that there were two separate problems: > 1) Large icons were not showing up in the Dock > 2) Backgrounds were black (i.e. alpha channel not properly encoded) > > The interim solutions should have had an impact on #1 - can you check that for > me? Here's my most recent conversation with my tester. The '> >' is me, '>' him. > > I created a test ICNS file containing icons which consist of nothing > > but > > a number matching the icon's dimensions against a transparent > > background. > > So, the 256x256 icon is a lime green "256". You should be able to > > see by > > inspection which icons are being used where now. Here's a special > > build > > containing the test icon: > > > > http://www.nomic.net/~uckelman/tmp/vassal/VASSAL-3.1.0-svn4990-icontest-macos > x.dmg > > Ah, an excellent test platform. > > So, the icon used for the general view of the file while it sits on > disk is the "128" icon. > > When the application launches, it also uses the 128 icon in the dock. > When the player is launched, it uses the 512 icon with black background. > > So, it seems that the java launcher is using a different method for > picking the dock icon than the standard Mac application launcher. The > latter, I guess, uses the largest icon that it can validate. The java > launcher just uses the large icon, even if it isn't fully valid. > > Now, when I look at the .icns file using IconComposer, only the icons > up to size 128 show up. > Looking at it in Preview, I see all of them, but the 256 and 512 have > black backgrounds. So it looks like we're only having the alpha channel problem now. We're setting the dock icon two different ways for two different parts of our app. The part launched from the app bundle is set from the Info.plist in the app bundle. The part launched directly using java has its dock icon set by using the -Xdock:icon flag. The difference we see in behavior between the two might be caused by the missing alpha channel in the large icons, or it might be caused by something else---we won't be able to tell until the alpha channel problem is fixed, which is itself a libicns problem. (In reply to comment #17) > Created an attachment (id=330198) [details] > VASSAL.icns generated from patched libicns > > I have made some more changes to libicns in the jp2 coding, and they appear to > work in my test cases on OS X 10.5. Please have your test the attached icon, > and if it looks successful, I will clean the fix up and merge it with the next > release of libicns. > > I am interested in knowing both the functionality of the icon in the dock, and > the appearance of the clear background. > > -Mathew Eis Thanks. My tester has it now. I'll let you know as soon as I hear back from him. Success! The last ICNS file you attached worked perfectly. Excellent. Expect a new upstream release of libicns within a week or two with the necessary fixes. -Mathew Eis Thanks much. I have released version 0.6.2 upstream, with the fixes that generated the successful test icns file. Others have tested it as working under 10.5.X. Please let me know if it works for you. -Mathew Eis I have just released v0.6.2 in rawhide. Releases for F-10 and F-9 will follow. Please test them and report here if the problem still persists. Looks good. Thanks. |