Bug 481410

Summary:	Review Request: perl-Mail-POP3Client - Perl 5 module to talk to a POP3 (RFC1939) server
Product:	[Fedora] Fedora	Reporter:	Ralf Corsepius <rc040203>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, panemade, vanmeeuwen+fedora
Target Milestone:	---	Flags:	panemade: fedora-review+ j: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-02-05 17:31:08 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	481411

Description Ralf Corsepius 2009-01-24 07:01:18 UTC

Spec URL: http://corsepiu.fedorapeople.org/packages/perl-Mail-POP3Client.spec
SRPM URL: http://corsepiu.fedorapeople.org/packages/perl-Mail-POP3Client-2.18-1.fc10.src.rpm
Description:
Perl 5 module to talk to a POP3 (RFC1939) server

Note: This package is an indirect dependency of rt3's testsuite.

Comment 1 Parag AN(पराग) 2009-01-24 12:39:49 UTC

Review:
+ package builds in mock.
 Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1079143
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
27b99775072f6ad4b585f7484c47405d  Mail-POP3Client-2.18.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ make test gave
All tests successful.
Files=1, Tests=26,  0 wallclock secs ( 0.01 usr  0.00 sys +  0.05 cusr  0.01 csys =  0.07 CPU)

+ Package: perl-Mail-POP3Client-2.18-1.fc11 =>
Provides: perl(Mail::POP3Client) = 2.18
Requires: perl(Carp) perl(Exporter) perl(IO::Socket) perl(strict) perl(vars) perl(warnings)

APPROVED.

Comment 2 Ralf Corsepius 2009-01-25 05:34:22 UTC

New Package CVS Request
=======================
Package Name: perl-Mail-POP3Client
Short Description: Perl 5 module to talk to a POP3 (RFC1939) server
Owners: corsepiu
Branches: F-10 F-9
InitialCC: perl-sig

Comment 3 Kevin Fenzi 2009-01-26 22:24:30 UTC

cvs done.

Comment 4 Parag AN(पराग) 2009-02-05 13:07:29 UTC

Is this built for requested branches? If yes then can we close this review?

Comment 5 Ralf Corsepius 2009-02-05 17:31:08 UTC

(In reply to comment #4)
> Is this built for requested branches?
meanwhile, yes ...
> If yes then can we close this review?
This Fedora buildsys should learn to automatically close reviews <~~~

Comment 6 Jeroen van Meeuwen 2010-06-25 04:33:47 UTC

Package Change Request
======================
Package Name: perl-Mail-POP3Client
New Branches: EL-5 EL-6
Owners: kanarip

Comment 7 Jason Tibbitts 2010-06-26 20:35:58 UTC

corseipu is listed as not contributing to EPEL.

CVS done.