Bug 481531 (perl-Test-Dynamic)
| Summary: | Review Request: perl-Test-Dynamic - Automatic test counting for Test::More | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Itamar Reis Peixoto <itamar> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade, rc040203 |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-03-04 05:45:53 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 481527 | ||
|
Description
Itamar Reis Peixoto
2009-01-26 02:51:39 UTC
You package does not comply to the FPG.
* Missing (mandatory):
Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
* Missing:
BuildRequires: perl(Test::More)
* Missing:
Permission fixing in %install.
I.e. add
%{_fixperms} %{buildroot}/*
or
%{__chmod} -R u+w %{buildroot}/*
at the end of the %install section
* Superfluous:
Requires: perl
* The testsuite works fine when providing the package with correct BR:'s
(Add BuildRequires: perl(Test::More) )
Non-blocking:
I dislike packages shipping testsuites in %doc, because these
a) occasionally introduce bogus deps due to defects in rpm's dependency generation.
b) offen don't work
c) add package bloat
... however, this is only my personal preference.
BTW: Are you familiar with Fedora's cpanspec tool? This tools eases significantly helps with getting started on packaging perl-modules for
Fedora.
next time I will try cpanspec tool please looks if like better now. http://ispbrasil.com.br/perl-Test-Dynamic/perl-Test-Dynamic.spec http://ispbrasil.com.br/perl-Test-Dynamic/perl-Test-Dynamic-1.3.3-2.fc10.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=1086995 1)I see working Source URL should be http://search.cpan.org/CPAN/authors/id/T/TU/TURNSTEP/Test-Dynamic-1.3.3.tar.gz 2) Enable make test 3) I see LICENSE is BSD. Also, This can be seen at http://search.cpan.org/dist/Test-Dynamic/ fixed. - Include make test in %%check section, fixed license, the correct is BSD - fixed sumary and descripton of this package - fixed source url http://ispbrasil.com.br/perl-Test-Dynamic/perl-Test-Dynamic.spec http://ispbrasil.com.br/perl-Test-Dynamic/perl-Test-Dynamic-1.3.3-3.fc10.src.rpm any news ? Looks Like I missed this to review after assigning myself. Review: + package builds in mock (rawhide i386). koji build=> http://koji.fedoraproject.org/koji/taskinfo?taskID=1099011 + rpmlint is silent for SRPM and for RPM. + source files match upstream url d1f92a8c14584d45b12d31e5ed942d4c Test-Dynamic-1.3.3.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs All tests successful. Files=3, Tests=9, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.22 cusr 0.03 csys = 0.27 CPU) + Package perl-Test-Dynamic-1.3.3-3.fc11 -> Provides: perl(Test::Dynamic) = 1.3.3 Requires: perl >= 0:5.008003 perl(strict) perl(utf8) perl(warnings) APPROVED. New Package CVS Request ======================= Package Name: perl-Test-Dynamic Short Description: Automatic test counting for Test::More Owners: itamarjp Branches: F-10 F-9 InitialCC: can you request cvs by setting fedora-cvs? flag? ping? look https://mail.endcrypt.com/pipermail/bucardo-general/2009-February/000191.html my real intention is to add bucardo into fedora, but Test::Dynamic is going away, it's not required to bucardo work, only required for testsuit, I don't like to include this package now and orphan it later. Can you take a look in bucardo review request ? Fine. Closing this review. |