Bug 481770
Summary: | Sesame's init script allows for starting multiple sesame daemons | ||
---|---|---|---|
Product: | Red Hat Enterprise MRG | Reporter: | Matthew Farrellee <matt> |
Component: | qpid-qmf | Assignee: | Matthew Farrellee <matt> |
Status: | CLOSED ERRATA | QA Contact: | Frantisek Reznicek <freznice> |
Severity: | high | Docs Contact: | |
Priority: | low | ||
Version: | 1.1 | CC: | esammons, gsim, iboverma, jneedle, jross, jsarenik, lans.carstensen, nsantos, tao, tross |
Target Milestone: | 1.3.2-RC2 | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | sesame-0.7.4297-5.el5 | Doc Type: | Bug Fix |
Doc Text: |
C: cumin init script would not detect service already running on start
C: Multiple cumin instances could be started at once
F: The init script now uses a subsys lock to avoid multiple runs
R: service cumin start is now idempotent
|
Story Points: | --- |
Clone Of: | Environment: | ||
Last Closed: | 2011-02-15 12:16:18 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Matthew Farrellee
2009-01-27 15:03:18 UTC
I think the sesame daemon itself should enforce singletonness. Do you agree, Ted? Quick crosscheck on beta1 [root@mrg-qe-02 qpid_ptest_authentication_krb5]# rpm -q sesame sesame-0.7.3918-1.el5 [root@mrg-qe-02 qpid_ptest_authentication_krb5]# service sesame status sesame is stopped [root@mrg-qe-02 qpid_ptest_authentication_krb5]# service sesame start Starting Sesame daemon: [ OK ] [root@mrg-qe-02 qpid_ptest_authentication_krb5]# service sesame status sesame (pid 4953) is running... [root@mrg-qe-02 qpid_ptest_authentication_krb5]# service sesame start Starting Sesame daemon: [ OK ] [root@mrg-qe-02 qpid_ptest_authentication_krb5]# service sesame status sesame (pid 5007 4953) is running... The issue is still present on sesame-0.7.3918-1.el5 It is still possible to run unlimited number of sesames from one host. sesame-0.7.3918-6.el5 Here is a simple patch to enforce the singleton nature from the init script. It should be sufficient to satisfy requirements with a small impact on sesame. As an side, it is valuable to be able to run many sesame daemons on a single machine. Index: cpp/etc/sysvinit-sesame =================================================================== --- cpp/etc/sysvinit-sesame (revision 4429) +++ cpp/etc/sysvinit-sesame (working copy) @@ -22,6 +22,10 @@ RETVAL=0 start() { + # Run only a single daemon + status $processname > /dev/null && exit 0 + rm -f /var/lock/subsys/$servicename + echo -n $"Starting Sesame daemon: " daemon --user sesame --check $servicename $processname $SESAME_OPTIONS\& RETVAL=$? The issue is not yet included in last packaged sesame version (sesame-0.7.4297-4.el5). See details below: [root@mrg-qe-02 ~]# service sesame status sesame (pid 4046) is running... [root@mrg-qe-02 ~]# service sesame start Starting Sesame daemon: [ OK ] [root@mrg-qe-02 ~]# service sesame status sesame (pid 26925 4046) is running... [root@mrg-qe-02 ~]# rpm -q sesame sesame-0.7.4297-4.el5.x86_64 [root@mrg-qe-02 ~]# Waiting for the package with fix. (s/The issue is not yet included/The issue patch is not yet included/ in comment 7) Technical note added. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. New Contents: C: cumin init script would not detect service already running on start C: Multiple cumin instances could be started at once F: The init script now uses a subsys lock to avoid multiple runs R: service cumin start is now idempotent Built sesame-0.7.4297-5.el5 to include the above patch. See https://brewweb.devel.redhat.com/buildinfo?buildID=154503 sesame-0.7.4297-5.el5 fixes the problem reliably. Waiting for el4 package to be able to close this defect. The issue has been fixed, tested on RHEL 4.8 / 5.6 i386 / x86_64 on package sesame-0.7.4297-5.el4/5 -> VERIFIED This is not a Cumin bug, I am setting it into management component. An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2011-0217.html |