Bug 482757
| Summary: | Review Request: objcryst-fox - Viewing and solving crystal structures from powder diffraction data | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Pascal Parois <pascal22p> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | david, fedora-package-review, notting, pingou, susi.lehtola |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-05-01 15:11:56 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
Pascal Parois
2009-01-27 21:43:56 UTC
New srpm: http://fedora.debroglie.net/SRPMS/10/objcryst-fox-1.8.0-2.fc10.debroglie.src.rpm New spec: http://svn.debroglie.net/specs/trunk/objcryst-fox.spec I runned the spec through mock, fedora 9/10 and epel 5 both x86_64 are ok. I corrected some errors on the build require Update to match new upstream release. srpm: http://fedora.debroglie.net/SRPMS/10/objcryst-fox-1.8.0.3-1.fc10.debroglie.src.rpm spec: http://svn.debroglie.net/specs/trunk/objcryst-fox.spec what's the rpmlint issue: rpmlint /home/builder/SPEC/objcryst-fox.spec rpmlint /home/builder/SRPMS/objcryst-fox-1.8.0.3-1.fc10.debroglie.src.rpm rpmlint /home/builder/RPMS/.... rpmlint is silent. I runned the spec through mock, fedora 9/10 and epel 5 both x86_64 and i386 are ok.
I cannot do the review since I'm not a sponsor but I looked at the spec file
Several minor points:
* You can use the macro %{name} instead of Fox in a number of places in the spec
ie:
> Source0: http://dfn.dl.sourceforge.net/sourceforge/objcryst/Fox-1.8.0.3-R1088.tar.bz2
becomes
> Source0: http://dfn.dl.sourceforge.net/sourceforge/objcryst/%{name}-%{version}-R1088.tar.bz2
that can save you some problem for later update
* Please add an extra \n between two change in the changelog (some tool used within Fedora need these white line between the change):
ie:
> * Sat Feb 14 2009 Pascal < pascal22p > - 1.8.0.3-1
> - Fixed reading, writing files and display of labels in the linux unicode version of Fox
> * Fri Feb 06 2009 Pascal < pascal22p > - 1.8.0-2
becomes
> * Sat Feb 14 2009 Pascal < pascal22p > - 1.8.0.3-1
> - Fixed reading, writing files and display of labels in the linux unicode version of Fox
It might be nice also to give to the reviewer an input file and an output file so that the software could actually be tested :)
You might also be interested to join the SciTech SIG:
https://fedoraproject.org/wiki/Category:SciTech_SIG
> * Fri Feb 06 2009 Pascal < pascal22p > - 1.8.0-2
(In reply to comment #5) > > * You can use the macro %{name} instead of Fox in a number of places in the The name of the package is not the name of the archive. I used the same name as debian used for their deb: http://packages.debian.org/fr/sid/objcryst-fox > > * Please add an extra \n between two change in the changelog (some tool used Done in the spec but new srpm/rpm not updated > > It might be nice also to give to the reviewer an input file and an output file > so that the software could actually be tested :) There are example files in /usr/share/doc/objcryst-fox... A tutorial is here: http://vincefn.net/Fox/Tutorials > > You might also be interested to join the SciTech SIG: > https://fedoraproject.org/wiki/Category:SciTech_SIG > Yes, good idea, I'll see when this get pushed in fedora. new srpm: http://fedora.debroglie.net/SRPMS/10/objcryst-fox-1.8.1.2-1.fc10.debroglie.src.rpm spec: http://svn.debroglie.net/specs/trunk/objcryst-fox.spec - Use %global instead of %define. Put the revision definition at the top of the spec file:
%global revision R1119
- Include the revision in the release tag:
Release: 2.%{revision}%{?dist}
(every time you update the spec file update the release tag if the version hasn't been updated).
- No explicit Requires: are allowed for libraries; drop
Requires: wxGTK, fftw, freeglut
http://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires
- Drop the commented patch line
#%patch0 -p0
- Instead of
find . -type d -name .svn -print0 | xargs -0r rm -rf
you can just use
find . -name *.svn -exec rm -rf {} \;
(or maybe even
find . -name *.svn -delete;
)
- Preserve time stamps by adding -p to install commands.
- Use "rm" instead of "unlink".
- Install the pixmap to /usr/share/pixmaps, drop the hicolor stuff. (Also, you were missing Requires: hicolor-icon-theme.)
(In reply to comment #8) > - Instead of > find . -type d -name .svn -print0 | xargs -0r rm -rf > you can just use > find . -name *.svn -exec rm -rf {} \; > (or maybe even > find . -name *.svn -delete; > ) Ugh, the .svn's are directories, so what you want to run is find . -name .svn -exec rm -rf {} \; ping? Sorry, notification mails got lost in my mailbox, I am still here, just very busy. So I'll look at this later. sometimes this month, as soon as I submit my thesis. As I need newmat-c++, I'll look at this one first (https://bugzilla.redhat.com/show_bug.cgi?id=479978) I am updating this package and ran into an issue. The release version does not compile, so I would like to use the beta version instead (which is working) but the versioning is 1.8.X The current version I have is 1.8.1 which is "newer" than 1.8.X. :( I don't if the next version will be 1.8.2 or 1.9. Any comments welcome nobody for review this package? By the way, new version: http://fedora.debroglie.net/SRPMS/12/objcryst-fox-1.9.0.2-1.R1215.fc12.src.rpm http://fedora.debroglie.net/RPMS/12/x86_64/objcryst-fox-1.9.0.2-1.R1215.fc12.x86_64.rpm http://redmine.debroglie.net/projects/debroglie/repository/entry/specs/trunk/objcryst-fox.spec http://fedora.debroglie.net/RPMS/14/i386/objcryst-fox-1.9.0.2-1.R1269.fc14.i686.rpm http://fedora.debroglie.net/SRPMS/14/objcryst-fox-1.9.0.2-1.R1269.fc14.src.rpm https://redmine.debroglie.net/projects/debroglie/repository/raw/specs/trunk/objcryst-fox.spec Pascal are you still interested in this packaging this?? I'll be happy to work to sponsor you if you are. Yes but I am a bit busy at the moment Ping Pascal? Still here. Last update (from august): http://depot.debroglie.net/fedora/RPMS/15/repoview/objcryst-fox.html https://svn.parois.net/debroglie/specs/trunk/objcryst-fox.spec It's outdated, the 1.9.7 is out. I put it on my todo list. Did you want to package 1.9.7 (or whatever is current now)? The above links don't seem to provide an actual srpm to review so there's not much anyone can do. Binary packages are of no use at all when reviewing. |