Bug 482811

Summary: authd fails with negative uid values
Product: [Fedora] Fedora Reporter: Tom Hughes <tom>
Component: authdAssignee: Roman Rakus <rrakus>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: jsafrane, rrakus, tsmetana
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: authd-1.4.3-40.fc20 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-08-05 10:02:28 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch to treat UID values as signed
none
Patch to treat UID values as signed
none
New version of UID patch none

Description Tom Hughes 2009-01-28 11:16:44 UTC
Description of problem:

If authd encounters a negative UID when reading /proc/net/tcp then it stops reading at that point, and may fail to identify the connection it is looking for.

Version-Release number of selected component (if applicable):

authd-1.4.3-21.fc10.x86_64

How reproducible:

A little tricky - you need to try and authenticate a connection that is listed after a connection with a negative UID in /proc/net/tcp... When you have such a case it will go wrong every time.

Actual results:

authd sends an error response to the client.

Expected results:

authd authenticates the connection.

Additional info:

Comment 1 Tom Hughes 2009-01-28 11:18:28 UTC
Created attachment 330221 [details]
Patch to treat UID values as signed

This is a patch against the clean 1.4.3 source to fix the handling of negative UID values.

Comment 2 Tom Hughes 2009-01-28 11:19:31 UTC
Created attachment 330222 [details]
Patch to treat UID values as signed

This is a patch that will apply against 1.4.3 with the current RPM patches (in particular the jiffies64 patch) to fix the handling of negative UID values.

Comment 3 Tom Hughes 2009-01-28 16:22:27 UTC
Created attachment 330243 [details]
New version of UID patch

This fixes the second version of the UID patch (the one that goes on top of jiffies) to correct an error derived from cut and pasting code from the jiffies patch (see bug #482865 for this error in the jiffies patch).

Comment 4 Tom Hughes 2009-09-07 13:50:54 UTC
This is still broken in Fedora 11.

Comment 5 Bug Zapper 2010-04-27 12:48:54 UTC
This message is a reminder that Fedora 11 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 11.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '11'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 11's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 11 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 6 Bug Zapper 2010-06-28 11:09:31 UTC
Fedora 11 changed to end-of-life (EOL) status on 2010-06-25. Fedora 11 is 
no longer maintained, which means that it will not receive any further 
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of 
Fedora please feel free to reopen this bug against that version.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 7 Roman Rakus 2013-08-05 10:02:28 UTC
Fixed in authd-1.4.3-40.fc20