Bug 482863
Summary: | Review Request: perl-MooseX-Daemonize - Role for daemonizing your Moose based application | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Allisson Azevedo <allisson> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | andrea.veri, fedora-package-review, iarnell, notting, panemade |
Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-02-05 13:13:48 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 482856 |
Description
Allisson Azevedo
2009-01-28 16:12:19 UTC
Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1090309 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 24ff349f0e2e09ca89e8ecbc73b0dc65 MooseX-Daemonize-0.08.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=9, Tests=82, 18 wallclock secs ( 0.06 usr 0.02 sys + 3.84 cusr 0.25 csys = 4.17 CPU) + Package perl-MooseX-Daemonize-0.08-1.fc11 => Provides: perl(MooseX::Daemonize) = 0.08 perl(MooseX::Daemonize::Core) = 0.01 perl(MooseX::Daemonize::Pid) = 0.01 perl(MooseX::Daemonize::Pid::File) = 0.01 perl(MooseX::Daemonize::WithPidFile) = 0.01 perl(Test::MooseX::Daemonize) = 0.03 perl(Test::MooseX::Daemonize::Testable) Requires: perl(Moose) perl(Moose::Role) perl(Moose::Util::TypeConstraints) perl(MooseX::Daemonize::Pid::File) perl(MooseX::Getopt) perl(MooseX::Getopt::OptionTypeMap) perl(MooseX::Types::Path::Class) perl(POSIX) perl(Sub::Exporter) perl(Test::Builder) perl(strict) APPROVED. Also, make sure to remove OPTIMIZE="$RPM_OPT_FLAGS" from %build as its not needed for this noarch kind of package. Can you please resubmit this package using cpanspec created SPEC file? Update package: Spec URL: http://allisson.fedorapeople.org/packages/perl-MooseX-Daemonize/perl-MooseX-Daemonize.spec SRPM URL: http://allisson.fedorapeople.org/packages/perl-MooseX-Daemonize/perl-MooseX-Daemonize-0.08-2.fc10.src.rpm Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1092737 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 24ff349f0e2e09ca89e8ecbc73b0dc65 MooseX-Daemonize-0.08.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=9, Tests=82, 15 wallclock secs ( 0.01 usr 0.01 sys + 1.91 cusr 0.26 csys = 2.19 CPU) + Package perl-MooseX-Daemonize-0.08-2.fc11 => Provides: perl(MooseX::Daemonize) = 0.08 perl(MooseX::Daemonize::Core) = 0.01 perl(MooseX::Daemonize::Pid) = 0.01 perl(MooseX::Daemonize::Pid::File) = 0.01 perl(MooseX::Daemonize::WithPidFile) = 0.01 perl(Test::MooseX::Daemonize) = 0.03 perl(Test::MooseX::Daemonize::Testable) Requires: perl(Moose) perl(Moose::Role) perl(Moose::Util::TypeConstraints) perl(MooseX::Daemonize::Pid::File) perl(MooseX::Getopt) perl(MooseX::Getopt::OptionTypeMap) perl(MooseX::Types::Path::Class) perl(POSIX) perl(Sub::Exporter) perl(Test::Builder) perl(strict) APPROVED. New Package CVS Request ======================= Package Name: perl-MooseX-Daemonize Short Description: Role for daemonizing your Moose based application Owners: allisson Branches: F-9 F-10 cvs done. is this built? http://koji.fedoraproject.org/koji/packageinfo?packageID=7616 Sorry, I forgot to close. Package Change Request ====================== Package Name: perl-MooseX-Daemonize InitialCC: perl-sig Please add perl-sig to this package with watchbugzilla and watchcommits bits on all fedora branches. Done. Package Change Request ====================== Package Name: perl-MooseX-Daemonize New Branches: el6 Owners: averi psabata InitialCC: perl-sig Git done (by process-git-requests). |