Bug 482880

Perl package source generally includes license test in its perl module source text files(.pm here say) only.

Suggestions:
1) SRPM when extracted got SPEC with License as  "Unknown" whereas SPEC file link shows correct license as "GPL+ or Artistic"

2) Summary should be 
"Perl extension for the SANE (Scanner Access Now Easy) Project"

3) %files should be
%files
%defattr(-,root,root,-)
%doc Changes README examples
%{perl_vendorarch}/auto/*
%{perl_vendorarch}/Sane*
%{_mandir}/man3/*

(In reply to comment #1)
> Perl package source generally includes license test in its perl module source
> text files(.pm here say) only.
> 
 s/test/text/

> Suggestions:
> 1) SRPM when extracted got SPEC with License as  "Unknown" whereas SPEC file
> link shows correct license as "GPL+ or Artistic"
> 
> 2) Summary should be 
> "Perl extension for the SANE (Scanner Access Now Easy) Project"
> 
> 3) %files should be
> %files
> %defattr(-,root,root,-)
> %doc Changes README examples
> %{perl_vendorarch}/auto/*
> %{perl_vendorarch}/Sane*
> %{_mandir}/man3/*

(In reply to comment #1)
> Perl package source generally includes license test in its perl module source
> text files(.pm here say) only.

The author thinks that the information in the README is sufficient.

> Suggestions:
> 1) SRPM when extracted got SPEC with License as  "Unknown" whereas SPEC file
> link shows correct license as "GPL+ or Artistic"

Someone I think I uploaded a file in progress - this has been fixed.
 
> 2) Summary should be 
> "Perl extension for the SANE (Scanner Access Now Easy) Project"

fixed

> 3) %files should be
> %files
> %defattr(-,root,root,-)
> %doc Changes README examples
> %{perl_vendorarch}/auto/*
> %{perl_vendorarch}/Sane*
> %{_mandir}/man3/*

fixed

Spec URL: http://fedorapeople.org/~bjohnson/perl-Sane.spec
SRPM URL: http://fedorapeople.org/~bjohnson/perl-Sane-0.02-2.fc10.src.rpm

Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1092739
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
03fa0ad2a50e18598d91f197924fb54d  Sane-0.02.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=5, Tests=323,  1 wallclock secs ( 0.07 usr  0.00 sys +  0.27 cusr  0.04 csys =  0.38 CPU)
+ Package  perl-Sane-0.02-2.fc11 =>
  Provides: Sane.so perl(Sane) = 0.02 perl(Sane::Device) perl(Sane::Status)
  Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libdl.so.2 libexif.so.12 libgphoto2.so.2 libgphoto2_port.so.0 libieee1284.so.3 libjpeg.so.62 libm.so.6 libpthread.so.0 libpthread.so.0(GLIBC_2.0) libsane.so.1 libusb-0.1.so.4 perl >= 0:5.008005 perl(Exporter) perl(overload) perl(strict) perl(warnings) rtld(GNU_HASH)

APPROVED.

Thanks Parag AN(पराग)!

New Package CVS Request
=======================
Package Name: perl-Sane
Short Description: Perl extension for the SANE (Scanner Access Now Easy) Project
Owners: bjohnson
Branches: F-10
InitialCC: fedora-perl-devel-list

cvs done.

perl-Sane-0.02-2.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.