Bug 482887
| Summary: | Values in new cf_partner field are getting reset | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Community] Bugzilla | Reporter: | Andrius Benokraitis <andriusb> | ||||
| Component: | Creating/Changing Bugs | Assignee: | Noura El hawary <nelhawar> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | |||||
| Severity: | urgent | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 3.2 | CC: | cward, dkl, eriley | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2009-01-29 16:51:00 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Andrius Benokraitis
2009-01-28 17:46:32 UTC
Found the second case... in this case all that was done was a user added themselves to the bug in the CC field and the Partner field was reset. https://bugzilla.redhat.com/show_bug.cgi?id=480204 Richard A Lary <rlary.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Partner|Qlogic | CC| |rlary.com Partner|Any | Giving to Noura. Created attachment 330359 [details]
v1 to fix problem with resetting partner and verified fields
Basically the problem is coming from the logic within the process_custom_field extension, I have fixed the logic, also the patch includes the following:
- I have moved out the redhat group check from the function can_see_partner, and renamed it can_set_partner, as the members of only the redhat group can just view the partner fields and they cant write or edit it so viewing is basically separate to most functionality that will be required to edit/write the fields so i separated it.
- I have added a fix to the column name of changed fields that appears in email notifications as i noticed that for both cf_verified and cf_partner changes the email had the name "Partner" so i changed that to be either Patner or Verified.
Noura
> - I have added a fix to the column name of changed fields that appears in email
> notifications as i noticed that for both cf_verified and cf_partner changes the
> email had the name "Partner" so i changed that to be either Patner or Verified.
>
^^^
I think this is the problem, because when a new partner is selected, the Verified field /should/ be automatically set to 'Any'. Partner field doesn't even have a 'Any' value. So it does seem when the email said 'Partner' it actually meant 'Verified'
(In reply to comment #4) > > - I have added a fix to the column name of changed fields that appears in email > > notifications as i noticed that for both cf_verified and cf_partner changes the > > email had the name "Partner" so i changed that to be either Patner or Verified. > > > > ^^^ > I think this is the problem, because when a new partner is selected, the > Verified field /should/ be automatically set to 'Any'. Partner field doesn't > even have a 'Any' value. So it does seem when the email said 'Partner' it > actually meant 'Verified' Yes you are right chris, a fix for that is included in the attached patch, Also please note that this fix is now applied to bz-web2 for testing if needed. Dave, if the patch looks good to you, please commit to cvs so we can include it in package that will be pushed today. Thanks, Noura Comment on attachment 330359 [details]
v1 to fix problem with resetting partner and verified fields
Looks good Noura.
Dave
(In reply to comment #6) > (From update of attachment 330359 [details]) > Looks good Noura. > Dave Thanks for the review Dave, all committed now to cvs Noura |