Bug 482903
Summary: | debugedit prints: canonicalization unexpectedly shrank by one character | ||
---|---|---|---|
Product: | Red Hat Enterprise Linux 5 | Reporter: | Jack Neely <jjneely> |
Component: | rpm | Assignee: | Panu Matilainen <pmatilai> |
Status: | CLOSED ERRATA | QA Contact: | Petr Sklenar <psklenar> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 5.3 | CC: | bperkins, herrold, jakub, jan.iven, jjneely, k.georgiou, ofourdan, orion, pnasrat, psklenar, rjones, roland, syeghiay, tao |
Target Milestone: | rc | Keywords: | Regression |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | 304121 | Environment: | |
Last Closed: | 2009-09-02 11:40:47 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 304121 | ||
Bug Blocks: | |||
Attachments: |
Description
Jack Neely
2009-01-28 18:56:49 UTC
Created attachment 333735 [details]
Proposed patch to restore old behavior
The behavior of "debugedit" has not changed, it was already reporting an error in previous updates of EL5.
However, with rpm-4.4.2.3 the script "find-debuginfo.sh" now stops if an error is reported by "debugedit", whereas it used to continue with the previous version rpm-4.4.2-48 that was shipping in Red hat Enterprise Linux up to 5.2.
As a result, some rpm that used to build with EL5.2 now fail in EL5.3. While the error is most likely in the source of the package itself, this is a change in behavior that is perceived as a regression ("it used to build, but not anymore").
The following (trivial) patch does not address the issue with debugedit, it just restores the old behavior so the script find-debuginfo.sh will not stop if "debugedit" fails, as it used to do up to EL 5.2.
Would that be acceptable for EL5.x?
I think that would be acceptable for 5.x. This bugzilla has Keywords: Regression. Since no regressions are allowed between releases, it is also being proposed as a blocker for this release. Please resolve ASAP. Created attachment 335710 [details]
Patch to add a mention in the rpmbuild.8 man page
This additional patch just adds the mention of the issue to the rpmbuild man page (the added text in English may need proof reading).
Please note that this patch does not include the other localized versions of the man page for rpmbuild (ie Polish and Japanese).
Created attachment 336443 [details]
Patch to add a mention in the rpmbuild.8 man page (now also including ja/rpmbuild.8 )
Updated patch including Japanese translation from mfuruta
Just for clarity, either these two patches:
- rpm-4.4.2.3-do-not-break-on-debugedit.patch
- rpm-4.4.2.3-do-not-break-on-debugedit-man-part2.patch
Or only this one:
- rpm-4.4.2.3-canon-fix.patch
Should be applied. The first two patches restore the previous behavior and document the error in the man page, whereas the latter addresses the issue in debugedit.
Comment on attachment 336254 [details] Patch to address the error in debugedit Patch from http://laiskiainen.org/tmp/debugedit-canon-fix.diff (slightly adapted) An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2009-1371.html |