Bug 482927

Summary:	attempt to virsh attach-disk of floppy doesn't work
Product:	[Community] Virtualization Tools	Reporter:	John Levon <levon>
Component:	libvirt	Assignee:	Daniel Veillard <veillard>
Status:	CLOSED UPSTREAM	QA Contact:
Severity:	medium	Docs Contact:
Priority:	low
Version:	unspecified	CC:	berrange, crobinso, xen-maint
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Other
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-05-25 16:01:07 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description John Levon 2009-01-28 20:54:54 UTC

First, virsh disables attaches of type floppy. However, even then,
the xend driver doesn't work. Floppy disks appear in (image (hvm... section
not as a device, and the code only knows how to call device create,
which xend can't deal with floppies. Since attaching floppies only
makes sense in HVM, and that only works offline, the code should
attempt to re-define the entire domain in this case to attach
the floppy.

Comment 1 Daniel Berrangé 2009-01-28 21:06:33 UTC

Actually this should work in same way as for CDROMs. ie you can't hot attach an entire CDROM device, but you can change the existing media backing it.

Sadly, AFAICT XenD is unable to change floppy drive media even though QEMU itself supports this.

Comment 2 Cole Robinson 2010-05-25 16:01:07 UTC

The specific floppy check has been dropped from virsh.c, and the host hotplug vs. XML updating has been clarified with new explicit attach device APIs. Closing as UPSTREAM.