Bug 482952

Summary: urlgrab does not raise an exception on ftp errors
Product: Red Hat Enterprise Linux 5 Reporter: Jeff Bastian <jbastian>
Component: python-urlgrabberAssignee: James Antill <james.antill>
Status: CLOSED WONTFIX QA Contact: BaseOS QE <qe-baseos-auto>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.3   
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-07-02 17:04:31 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 445862    
Attachments:
Description Flags
demo script none

Description Jeff Bastian 2009-01-28 23:24:24 UTC 
Description of problem:
The python-urlgrabber module fails to raise an exception from ftp errors.

Try to urlgrab() a non-existing file from an ftp server and urlgrab() will not raise an exception and just create an empty file.

This bug is breaking anaconda's ability to correctly determine if the RHEL CD-ROM ISOs are loopback mounted on an ftp server.

Version-Release number of selected component (if applicable):
python-urlgrabber-3.1.0-5.el5.noarch

How reproducible:
every time

Steps to Reproduce:
1. use attached script to download the non-existing file ftp://ftp.redhat.com/pub/foo.txt
  
Actual results:
script reports a successful download

Expected results:
urlgrab should raise an exception

Additional info:
ftp://ftp.redhat.com/pub/foo.txt really does not exist
   $ lftp -e 'get pub/foo.txt; exit' ftp.redhat.com
   get: Access failed: 550 Failed to open file. (pub/foo.txt)
Comment 1 Jeff Bastian 2009-01-28 23:25:06 UTC 
Created attachment 330299 [details]
demo script
Comment 2 Jeff Bastian 2009-01-28 23:26:47 UTC 
Example run of demo script from comment #1

   $ ./get-redhat-foo.py
   Saved as foo.txt
   $ cat foo.txt
   $
Comment 3 RHEL Program Management 2009-03-26 17:22:04 UTC 
This request was evaluated by Red Hat Product Management for
inclusion, but this component is not scheduled to be updated in
the current Red Hat Enterprise Linux release. If you would like
this request to be reviewed for the next minor release, ask your
support representative to set the next rhel-x.y flag to "?".
Comment 4 RHEL Program Management 2009-11-06 19:22:40 UTC 
This request was evaluated by Red Hat Product Management for
inclusion, but this component is not scheduled to be updated in
the current Red Hat Enterprise Linux release. If you would like
this request to be reviewed for the next minor release, ask your
support representative to set the next rhel-x.y flag to "?".
Comment 5 James Antill 2010-07-02 16:56:39 UTC 
There's no patch, urlgrabber in RHEL-6 is v. different and there's no IT linked ... so I'm going to NAK this.
Comment 6 RHEL Program Management 2010-07-02 17:04:31 UTC 
Development Management has reviewed and declined this request.  You may appeal
this decision by reopening this request.