Bug 483116
| Summary: | Review Request: grnotify - Google Reader Notifier | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Guillaume Kulakowski <guillaume> | ||||
| Component: | Package Review | Assignee: | Joseph Smidt <josephsmidt> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 10 | CC: | fedora-package-review, josephsmidt, notting | ||||
| Target Milestone: | --- | Flags: | josephsmidt:
fedora-review+
kevin: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | noarch | ||||||
| OS: | Linux | ||||||
| URL: | http://grnotify.sourceforge.net/ | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | 1.1.2-4.fc10 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2009-03-09 22:56:35 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Guillaume Kulakowski
2009-01-29 18:49:46 UTC
Fredonnement… La version 1.1.1 a été libérée peu d'heures avant ma demande… Je fais aller rapidement la construction T/MN avant week-end : SPEC: http://llaumgui.fedorapeople.org/review/grnotify/grnotify.spec SRPMS: http://llaumgui.fedorapeople.org/review/grnotify/grnotify-1.1.1-1.fc10.noarch.rpm RPM: http://llaumgui.fedorapeople.org/review/grnotify/grnotify-1.1.1-1.fc10.src.rpm Commment: builder@enterprise ~> rpmlint rpmbuild/RPMS/noarch/grnotify-1.1.1-1.fc10.noarch.rpm 21:45 grnotify.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/grnotify/GoogleReader.py 0644 Version 1.1.2 SPEC: http://llaumgui.fedorapeople.org/review/grnotify/grnotify.spec SRPMS: http://llaumgui.fedorapeople.org/review/grnotify/grnotify-1.1.2-1.fc10.noarch.rpm RPM: http://llaumgui.fedorapeople.org/review/grnotify/grnotify-1.1.2-1.fc10.src.rpm Commment: rpmlint is silent Version 1.1.2 SPEC: http://llaumgui.fedorapeople.org/review/grnotify/grnotify.spec SRPMS: http://llaumgui.fedorapeople.org/review/grnotify/grnotify-1.1.2-2.fc10.noarch.rpm RPM: http://llaumgui.fedorapeople.org/review/grnotify/grnotify-1.1.2-2.fc10.src.rpm Commment: rpmlint is silent I will take up reviewing this package. As packaging goes, it all seems good. :) (See attachment) However, are you sure you need gnome-icon-theme as a Requires? It is not mentioned on the webpage: http://grnotify.sourceforge.net/install.html or in the sources as a dependency. When I run the package it seems to run just fine. However, when I close out and open it back up it does not remember my username and password. When I run in a terminal I get this output: /usr/bin/grnotify:591: GtkWarning: GtkSpinButton: setting an adjustment with non-zero page size is deprecated self.xml = gtk.glade.XML(self.gladefile) Then, when I hit "Save" to save my username and password I get this output Traceback (most recent call last): File "/usr/bin/grnotify", line 711, in on_save_button_clicked grnotify_app.saveConfig() File "/usr/bin/grnotify", line 75, in saveConfig if not self.useKeyRing or not self.saveKeyRing(self.passwd): File "/usr/bin/grnotify", line 130, in saveKeyRing except gnomekeyring.AlreadyExistsError: UnboundLocalError: local variable 'gnomekeyring' referenced before assignment Created attachment 332179 [details]
Review of package
Here is the Review attachment.
Hi, Thx Joseph. I contact the author for this bug, and I propose a setup.py for a better clean installation and packaging. Hi, gnome-icon-theme is an error of my part. I have proposed to the author a new setup.py for a easiers packaging : https://sourceforge.net/tracker2/?func=detail&aid=2609868&group_id=217132&atid=1039328 Has the author responded? Do you have a new Spec/Srpm that I could review? Hi, no response. But a new SPEC without path for install.py but a new setup.py that I proposed to the author Version 1.1.2-3 SPEC: http://llaumgui.fedorapeople.org/review/grnotify/grnotify.spec SRPMS: http://llaumgui.fedorapeople.org/review/grnotify/grnotify-1.1.2-3.fc10.noarch.rpm RPM: http://llaumgui.fedorapeople.org/review/grnotify/grnotify-1.1.2-3.fc10.src.rpm Commment: rpmlint is silent Sorry, I got busy for a couple days. It looks good. Approved. New Package CVS Request ======================= Package Name: grnotify Short Description: Google Reader Notifier Owners: llaumgui Branches: F-9 F-10 InitialCC: Can you fix your usage of --vendor here? From the guidelines: "For new packages, do not apply a vendor tag to desktop files" OK Correction made in http://llaumgui.fedorapeople.org/review/grnotify/grnotify.spec Thanks. cvs done. grnotify-1.1.2-4.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/grnotify-1.1.2-4.fc10 grnotify-1.1.2-4.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/grnotify-1.1.2-4.fc9 grnotify-1.1.2-4.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update grnotify'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-2075 grnotify-1.1.2-4.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update grnotify'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-2077 grnotify-1.1.2-4.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. grnotify-1.1.2-4.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |