Bug 483553 (mingw32-libltdl)

FYI: When I publish updates to this package in the course of this review, they will be published here:

  http://ndim.fedorapeople.org/packages/mingw32-libltdl/
  http://fedorapeople.org/gitweb?p=ndim/public_git/mingw32-libltdl-package.git;a=summary
  git://fedorapeople.org/~ndim/mingw32-libltdl-package.git

A Koji scratch build would help here to validate
that there are no missing dependencies, and that it
actually builds in the somewhat harsh environment
of mock/koji.

Updated versions:

  http://ndim.fedorapeople.org/packages/mingw32-libltdl/1.5.26-9.fc10/
  http://ndim.fedorapeople.org/packages/mingw32-libltdl/1.5.26-8.fc10/

For detailed changes, cf. the mingw32-libltdl.spec files, or see the gitweb interface.

Koji scratch builds complete successfully:

  http://koji.fedoraproject.org/koji/taskinfo?taskID=1099167 (1.5.26-9.fc10)
  http://koji.fedoraproject.org/koji/taskinfo?taskID=1099134 (1.5.26-8.fc10)

%changelog
* Mon Feb  2 2009 Hans Ulrich Niedermann <hun> - 1.5.26-9
- remove obsolete requires(post/pre)
- remove mingw32-gcc-c++ requirement

* Mon Feb  2 2009 Hans Ulrich Niedermann <hun> - 1.5.26-8
- Call configure with --host instead of setting CC and CXX.
- Use BuildArch: noarch

Koji scratch build of mingw32-libltdl-1.5.26-9.fc10 for dist-f11:

  http://koji.fedoraproject.org/koji/taskinfo?taskID=1099174

Minimal change since last koji scratch build, so I did not do another one:

  http://ndim.fedorapeople.org/packages/mingw32-libltdl/1.5.26-10.fc10/

* Mon Feb  2 2009 Hans Ulrich Niedermann <hun> - 1.5.26-10
- fix license: only consider content of binary RPM

Taking for review.

General comments:

. You shouldn't need --host parameter to configure.

. It would be nice if the make check rule was surrounded by
  %if %{run_tests} ... %endif, and if it worked when run_tests
  was enabled.  (run_tests should be disabled by default though).
  See how we do it here:
  http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/9ce8bc84c7bc/gmp/mingw32-gmp.spec#l7

+ rpmlint output

mingw32-libltdl.src:56: W: configure-without-libdir-spec

Weird one - we set --libdir in the mingw32_configure macro so I'm
not sure what rpmlint is talking about.  Ignore it.

+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
+ license matches the actual package license
+ %doc includes license file
+ spec file written in American English
+ spec file is legible
+ upstream sources match sources in the srpm
+ package successfully builds on at least one architecture
n/a ExcludeArch bugs filed
+ BuildRequires list all build dependencies
+ %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and %postun
+ does not use Prefix: /usr
n/a package owns all directories it creates
+ no duplicate files in %files
+ %defattr line
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
+ files marked %doc should not affect package
n/a header files should be in -devel
n/a static libraries should be in -static
n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a -devel must require the fully versioned base
n/a packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
n/a packages must not own files or directories owned by other packages
n/a %install must start with rm -rf %{buildroot} etc.
+ filenames must be valid UTF-8

Optional:

n/a if there is no license file, packager should query upstream
n/a translations of description and summary for non-English languages, if available
+ reviewer should build the package in mock
+ the package should build into binary RPMs on all supported architectures
- review should test the package functions as described
n/a scriptlets should be sane
n/a pkgconfig files should go in -devel
+ shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin

===> APPROVED
but it would be nice to see the two changes I point out at the top.

(In reply to comment #7)
> General comments:
> 
> . You shouldn't need --host parameter to configure.

Removed in mingw32-libltdl-1.5.26-11.fc10

> . It would be nice if the make check rule was surrounded by
>   %if %{run_tests} ... %endif, and if it worked when run_tests
>   was enabled.  (run_tests should be disabled by default though).

Added in mingw32-libltdl-1.5.26-11.fc10

> ===> APPROVED
> but it would be nice to see the two changes I point out at the top.

Done:
  http://ndim.fedorapeople.org/packages/mingw32-libltdl/1.5.26-11.fc10/
  http://fedorapeople.org/gitweb?p=ndim/public_git/mingw32-libltdl-package.git;a=summary

Thanks for the review.

New Package CVS Request
=======================
Package Name: mingw32-libltdl
Short Description: Runtime libraries for GNU Libtool Dynamic Module Loader
Owners: ndim
Branches: F-10
InitialCC:

cvs done.

Built package for rawhide (CVS tag mingw32-libltdl-1.5.26-12.fc11).

Built package for F-10 (CVS tag mingw32-libltdl-1.5.26-12.fc10) and submitted for updates-testing.

Closing review request bug accordingly. Thanks for all the help.