Bug 483575
| Summary: | Review Request: dissy - Graphical frontend to the objdump disassembler | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lubomir Rintel <lkundrak> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | 10 | CC: | fedora-package-review, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-02-06 10:43:01 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Lubomir Rintel
2009-02-02 14:53:49 UTC
Files don't contain licensing information, only the COPYING file with text of GPLv2 is included. Upstream was contacted. Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1099565 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 2e48d6fec7c02c0e62a568a7e56ea374 dissy-8.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Desktop file installed correctly. + GUI app. Suggestion: 1) You still need following %if 0%{?fedora} > 8 %{python_sitelib}/*.egg-info %endif I will say drop this if-endif as F8 is EOL. and let there be only egg-info line. 2) Add correct BR:python-setuptools-devel for egg-info as per given at https://fedoraproject.org/wiki/Packaging/Python/Eggs APPROVED. I see Close button in About window not working. ping? Can you request cvs now? New Package CVS Request ======================= Package Name: dissy Short Description: Graphical frontend to the objdump disassembler Owners: lkundrak Branches: EL-5 (In reply to comment #3) > I see Close button in About window not working. Thanks for noticing it. I have a fix, it will be applied upon import. cvs done. Imported and built. |