Bug 483730
| Summary: | Review Request: kde-plasma-translatoid - A Google Translation Plasmoid | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Eli Wapniarski <eli> | ||||
| Component: | Package Review | Assignee: | Jaroslav Reznik <jreznik> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | rawhide | CC: | fedora-package-review, jreznik, notting, rdieter, xjakub | ||||
| Target Milestone: | --- | Flags: | jreznik:
fedora-review+
kevin: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | kde-plasma-translatoid-1.30-2.svn01092011.fc13 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2009-02-25 16:23:21 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Eli Wapniarski
2009-02-03 12:25:02 UTC
rpmlint output: kde-plasma-translatoid.src: E: invalid-spec-name - missing 's' in spec filename kde-plasma-translatoid.src: E: no-cleaning-of-buildroot %install - same as for #483728 kde-plasma-translatoid.src: W: summary-not-capitalized translator using google translator - capitalize summary, description too kde-plasma-translatoid.x86_64: W: spurious-executable-perm /usr/share/doc/kde-plasma-translatoid-0.4.1/README kde-plasma-translatoid.x86_64: W: incoherent-version-in-changelog 0.4.1 ['0.4.1-1.fc10', '0.4.1-1'] - same as for #483728 - license GPLv2+ - I'm not sure about Google trademarks, let me check - URL should be http://www.kde-look.org/content/show.php/translatoid?content=97511 - you should use 97511-translatoid%{version} in Source0 - remove flags due to Fedora policy - use build root consistently - rm -rf $RPM_BUILD_ROOT -> rm -rf ${buildroot} OK.. I believe that I should withdraw this because of the flag issue. Any thoughts. No no, that's not necessary at all, just remove the flags, e.g. by inserting:
sed -i -e 's/-fno-exceptions -fno-check-new -fno-common//' \
-e 's/-fno-threadsafe-statics -fvisibility=hidden -fvisibility-inlines-hidden//' \
-e 's/-ansi//' %{_target_platform}/CMakeFiles/translatoid.dir/flags.make
before
make %{?_smp_mflags} -C %{_target_platform}
PS: Jaroslav, speaking about cflags, you should do the same in your kde-plasma-quickaccess:)
(In reply to comment #3) > No no, that's not necessary at all, just remove the flags, e.g. by inserting: > > sed -i -e 's/-fno-exceptions -fno-check-new -fno-common//' \ > -e 's/-fno-threadsafe-statics -fvisibility=hidden > -fvisibility-inlines-hidden//' \ > -e 's/-ansi//' %{_target_platform}/CMakeFiles/translatoid.dir/flags.make > I've confirmed that flags.make is where the sed command looks for it. But, rpmbuild still wants to install the flags. I've not included the sed command in the spec file. All other indicated corrections and implied suggestions (visa vi Google). All files seem to pass the rpmlint test Spec URL: http://orbsky.homelinux.org/packages/kde-plasma-translatoid.spec Spec URL: ftp://orbsky.homelinux.org/pub/packages/kde-plasma-translatoid.spec SRPM URL: http://orbsky.homelinux.org/packages/kde-plasma-translatoid-0.4.1-2.fc10.src.rpm SRPM URL: ftp://orbsky.homelinux.org/pub/packages/http://orbsky.homelinux.org/packages/kde-plasma-translatoid-0.4.1-2.fc10.src.rpm Any additional help with removing the flags from the package would be greatly appreciated. (In reply to comment #4) > (In reply to comment #3) > > No no, that's not necessary at all, just remove the flags, e.g. by inserting: > > > > sed -i -e 's/-fno-exceptions -fno-check-new -fno-common//' \ > > -e 's/-fno-threadsafe-statics -fvisibility=hidden > > -fvisibility-inlines-hidden//' \ > > -e 's/-ansi//' %{_target_platform}/CMakeFiles/translatoid.dir/flags.make > > > I've confirmed that flags.make is where the sed command looks for it. But, > rpmbuild still wants to install the flags. I've not included the sed command in > the spec file. These compilation flags are not uncommon for KDE (or C++) sources, e.g. http://koji.fedoraproject.org/koji/buildinfo?buildID=81037 (In reply to comment #5) > These compilation flags are not uncommon for KDE (or C++) sources, > e.g. > http://koji.fedoraproject.org/koji/buildinfo?buildID=81037 Without a doubt. However, the compilation flag suggested did not work. And since I am no programmer, I would be very hard pressed to know the correct flags or syntax. Hence, the request for additional assistance. I tried to install this widget and the problem is that it's unusable without flags - flags are used in language chooser... - rpmlint output is clean - OK problems: - capitalize description - do not use TM - https://fedoraproject.org/wiki/Packaging:Guidelines#Trademarks_in_Summary_or_Description OK... That should be that except for the flag issue. Spec URL: http://orbsky.homelinux.org/packages/kde-plasma-translatoid.spec Spec URL: ftp://orbsky.homelinux.org/pub/packages/kde-plasma-translatoid.spec SRPM URL: http://orbsky.homelinux.org/packages/kde-plasma-translatoid-0.4.1-3.fc10.src.rpm SRPM URL: ftp://orbsky.homelinux.org/pub/packages/http://orbsky.homelinux.org/packages/kde-plasma-translatoid-0.4.1-3.fc10.src.rpm And maybe at least description should be more informative - it's Plasma widget etc... I'm really not sure about inclusion of flags - we should wait until someone from KDE-SIG asks Fedora legal/board - KDE-SIG is planning to ask... Without approval from them I can't approve this package for Fedora. Or we can prepare patch to show label instead flag. Wait wait -- I just realized that I'm not sure whether we speak about the same issue: What I told you is how to remove the additional non-Fedora GCC compiler flags. I revisited the sed script, it was just wrong wrapped after pasting into bugzilla, hence once again:
"
sed -i -e 's/-fno-exceptions -fno-check-new -fno-common//' \
-e 's/-fno-threadsafe-statics -fvisibility=hidden -fvisibility-inlines-hidden//' \
-e 's/-ansi//' %{_target_platform}/CMakeFiles/translatoid.dir/flags.make
"
This should definitely help to get rid of all of the flags, yesterday I downloaded your SRPM and tested it.
!Note: This has *nothing* to do with the country flags, it's completely unrelated.
> These compilation flags are not uncommon for KDE (or C++) sources,
> e.g.
> http://koji.fedoraproject.org/koji/buildinfo?buildID=81037
Do you mean we should leave them as they are?
(In reply to comment #11) > Wait wait -- I just realized that I'm not sure whether we speak about the same > issue: What I told you is how to remove the additional non-Fedora GCC compiler > flags. I revisited the sed script, it was just wrong wrapped after pasting into > bugzilla, hence once again: > > ... > > !Note: This has *nothing* to do with the country flags, it's completely > unrelated. So it's misunderstanding - country flags are legal problem! Ooops sorry about the misunderstanding. I thought you were pointing out an issue discussed relatively recently on the fedora-kde mailing list. So... OK.. Done. Spec URL: http://orbsky.homelinux.org/packages/kde-plasma-translatoid.spec Spec URL: ftp://orbsky.homelinux.org/pub/packages/kde-plasma-translatoid.spec SRPM URL: http://orbsky.homelinux.org/packages/kde-plasma-translatoid-0.4.1-4.fc10.src.rpm SRPM URL: ftp://orbsky.homelinux.org/pub/packages/http://orbsky.homelinux.org/packages/kde-plasma-translatoid-0.4.1-4.fc10.src.rpm Created attachment 331005 [details]
This patch removes country flags
Try this patch - it changes country flags to country code...
And please correct URL in package - there's still bad one. Ooops Spec URL: http://orbsky.homelinux.org/packages/kde-plasma-translatoid.spec Spec URL: ftp://orbsky.homelinux.org/pub/packages/kde-plasma-translatoid.spec SRPM URL: http://orbsky.homelinux.org/packages/kde-plasma-translatoid-0.4.1-4.fc10.src.rpm SRPM URL: ftp://orbsky.homelinux.org/pub/packages/kde-plasma-translatoid-0.4.1-4.fc10.src.rpm Thanks for this... Seems that there is a problem with with it though as I get the following when trying to apply it. Patch #1 (translatoid-ban-flags.patch): + /bin/cat /home/eli/rpmbuild/SOURCES/translatoid-ban-flags.patch + /usr/bin/patch -s -p0 --fuzz=0 The text leading up to this was: -------------------------- |diff -up translatoid2/CMakeLists.txt.ban-flags translatoid2/CMakeLists.txt |--- translatoid2/CMakeLists.txt.ban-flags 2009-02-05 16:43:57.000000000 +0100 |+++ translatoid2/CMakeLists.txt 2009-01-30 22:08:11.000000000 +0100 -------------------------- File to patch: You need -p1 not -p0 but still patch was bad - I reverted order for CMakeLists.txt. Spec URL: http://rezza.hofyland.cz/fedora/packages/kde-plasma-translatoid/kde-plasma-translatoid.spec SRPM URL: http://rezza.hofyland.cz/fedora/packages/kde-plasma-translatoid/kde-plasma-translatoid-0.4.1-5.fc10.src.rpm Patch URL: http://rezza.hofyland.cz/fedora/packages/kde-plasma-translatoid/kde-plasma-translatoid-ban-flags.patch I just confirmed. The change you made did the trick. Since you already did this bit of work I should leave the urls that you provided as is. Is that correct? I just confirmed. The change you made did the trick. Since you already did this bit of work I should leave the urls that you provided as is. Is that correct? However, 2 flags seem to persist. The flag of the UK and France. Also, after looking at the results, the language selector diaolog box becomes really ugly. More and more, I think this package belongs in a third party repo because of the country flags. Ooop. I wrote to soon. All the flags are gone, replaced with question marks. So something is wrong - there should be no flags at all! Flags are replaced with language code label. Try to restart Plasma to load new package. It's usable even without flags, only it doesn't look so visually appealing. My SPEC should be final one but depends on resolution of issues with question flags. OK... I gotcha. Restarted plasma and the icons completely disappered. Leaving only a list of Languages in the picker and how the program labels the country codes. Let the review begin. Jaroslav... OK... I gotta ask a maybe dumb question. I can wait if it is required. I'm only asking because of the frequency of activity and what seems to be a slow down in it. Since you submitted the last set of changes; does that mean that somebody else should conduct the review? (In reply to comment #24) > OK... I gotcha. Restarted plasma and the icons completely disappered. Leaving > only a list of Languages in the picker and how the program labels the country > codes. > > Let the review begin. Ok, so I think finish it now - the question is maintenance of this patched package... (In reply to comment #25) > Jaroslav... > > OK... I gotta ask a maybe dumb question. I can wait if it is required. I'm only > asking because of the frequency of activity and what seems to be a slow down in > it. > > Since you submitted the last set of changes; does that mean that somebody else > should conduct the review? Anyone can assist this review but assigned person should finish the review. Reviews could be really slow process - I'm waiting for one review months, in other review I'm waiting for packager months... Understood. Latest SPEC/SRPM files Spec URL: http://rezza.hofyland.cz/fedora/packages/kde-plasma-translatoid/kde-plasma-translatoid.spec SRPM URL: http://rezza.hofyland.cz/fedora/packages/kde-plasma-translatoid/kde-plasma-translatoid-0.4.1-6.fc10.src.rpm Patch URL: http://rezza.hofyland.cz/fedora/packages/kde-plasma-translatoid/kde-plasma-translatoid-ban-flags.patch As this is simple package, quick review: - rpmlint output clean - OK - country flags removed - OK (see comments #19, #24) - SPEC file - OK - trademarks - OK - koji scratch build (http://koji.fedoraproject.org/koji/taskinfo?taskID=1114840) - OK So for me package looks OK but I'll rather wait for comment on countries flags issue. Let me ask on fedora-kde list. the flags in source is ok, afaik. We simply don't want them *used*. Jaroslav Just in case you missed this. Looks like Rex has given his OK. (In reply to comment #30) > Jaroslav > > Just in case you missed this. Looks like Rex has given his OK. So then it's OK for me too. If you are willing to maintain it this patch or better should be ask upstream about flags issue. APPROVED Thanks for that... I really do not know what I need to ask regarding the patch. Regarding maintaining it, like I indicated, I am not a programmer. Will kompare handle the creation of patches. (In reply to comment #32) > Thanks for that... > > I really do not know what I need to ask regarding the patch. Regarding > maintaining it, like I indicated, I am not a programmer. Will kompare handle > the creation of patches. Ask them to replace flags with country codes or let user choose. The patch is really easy, so you don't have to be programmer to take care about it. And of course I can help you as comaintainer - just add me to CVS request. OK. What I'm going to ask is that the developer add a flag for cmake so that a package maintainer can throw the --without-countryflags. equivalent in cmake. Do you concur? New Package CVS Request ======================= Package Name: kde-plasma-translatoid Short Description: Translator plasmoid using Google Translator Owners: eliwap jreznik Branches: f-9 f-10 InitialCC: rdieter cvs done. Jaroslav - Patch creation time (sorry). There is a newer version of the plasmoid this version adds the ability to get the computer to speak the results of the translation. A very cool feature I think. So. I would very much like to get this version patched before I start building the packages The current spec has the lines referring to the patches commented out so that I could make sure the application compiles, installs and runs. It does. And of course I had to add the lines that installed the country flags. I've made the request to the developer of the plasmoid over at: http://kde-look.org/content/show.php/translatoid?content=97511 to give us an option to disable the country flags at compile time. He will be exploring two possibilities; to provide a cmake flag to disable the flags, or to provide the flags in a separate archive. In any case he is working on it. The urls to the current spec and srpms follow. Thanks Spec URL: http://orbsky.homelinux.org/packages/kde-plasma-translatoid.spec Spec URL: ftp://orbsky.homelinux.org/pub/packages/kde-plasma-translatoid.spec SRPM URL: http://orbsky.homelinux.org/packages/kde-plasma-translatoid-0.5-1.fc10.src.rpm SRPM URL: ftp://orbsky.homelinux.org/pub/packages/kde-plasma-translatoid-0.5-1.fc10.src.rpm kde-plasma-translatoid-0.4.1-6.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. kde-plasma-translatoid-0.4.1-6.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. kde-plasma-translatoid-0.6-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/kde-plasma-translatoid-0.6-2.fc10 kde-plasma-translatoid-0.6-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/kde-plasma-translatoid-0.6-2.fc9 kde-plasma-translatoid-0.6-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. kde-plasma-translatoid-0.6-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. kde-plasma-translatoid-0.9-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/kde-plasma-translatoid-0.9-1.fc11 kde-plasma-translatoid-0.9-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/kde-plasma-translatoid-0.9-1.fc10 kde-plasma-translatoid-0.9-1.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/kde-plasma-translatoid-0.9-1.fc9 kde-plasma-translatoid-0.9-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. kde-plasma-translatoid-0.9-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. kde-plasma-translatoid-1.0-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/kde-plasma-translatoid-1.0-1.fc10 kde-plasma-translatoid-1.0-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. kde-plasma-translatoid-1.1-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/kde-plasma-translatoid-1.1-1.fc11 kde-plasma-translatoid-1.1-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/kde-plasma-translatoid-1.1-1.fc12 kde-plasma-translatoid-1.1-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. kde-plasma-translatoid-1.1-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. kde-plasma-translatoid-1.1.90_20100122svn-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/kde-plasma-translatoid-1.1.90_20100122svn-1.fc12 kde-plasma-translatoid-1.1.90_20100122svn-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/kde-plasma-translatoid-1.1.90_20100122svn-1.fc11 kde-plasma-translatoid-1.1.90_20100122svn-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. kde-plasma-translatoid-1.1.90_20100122svn-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. kde-plasma-translatoid-1.1.90_20100122svn-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/kde-plasma-translatoid-1.1.90_20100122svn-2.fc12 kde-plasma-translatoid-1.1.90_20100122svn-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/kde-plasma-translatoid-1.1.90_20100122svn-2.fc13 kde-plasma-translatoid-1.1.90_20100122svn-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/kde-plasma-translatoid-1.1.90_20100122svn-2.fc11 kde-plasma-translatoid-1.1.90_20100122svn-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. kde-plasma-translatoid-1.1.90_20100122svn-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. kde-plasma-translatoid-1.1.90_20100122svn-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. kde-plasma-translatoid-1.20-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/kde-plasma-translatoid-1.20-1.fc12 kde-plasma-translatoid-1.20-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/kde-plasma-translatoid-1.20-1.fc13 kde-plasma-translatoid-1.20-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/kde-plasma-translatoid-1.20-1.fc11 kde-plasma-translatoid-1.21-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/kde-plasma-translatoid-1.21-1.fc12 kde-plasma-translatoid-1.21-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/kde-plasma-translatoid-1.21-1.fc11 kde-plasma-translatoid-1.21-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/kde-plasma-translatoid-1.21-1.fc13 kde-plasma-translatoid-1.21-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. kde-plasma-translatoid-1.21-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. kde-plasma-translatoid-1.21-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. kde-plasma-translatoid-1.30-1.fc12 has been submitted as an update for Fedora 12. https://admin.fedoraproject.org/updates/kde-plasma-translatoid-1.30-1.fc12 kde-plasma-translatoid-1.30-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/kde-plasma-translatoid-1.30-1.fc13 kde-plasma-translatoid-1.30-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/kde-plasma-translatoid-1.30-1.fc14 kde-plasma-translatoid-1.30-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. kde-plasma-translatoid-1.30-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. kde-plasma-translatoid-1.30-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. kde-plasma-translatoid-1.30-2.svn01092011.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/kde-plasma-translatoid-1.30-2.svn01092011.fc14 kde-plasma-translatoid-1.30-2.svn01092011.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/kde-plasma-translatoid-1.30-2.svn01092011.fc13 kde-plasma-translatoid-1.30-2.svn01092011.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. kde-plasma-translatoid-1.30-2.svn01092011.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |