Bug 483868
Summary: | Review Request: iscan-firmware - Firmware for Epson flatbed scanners | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Dominik 'Rathann' Mierzejewski <dominik> |
Component: | Package Review | Assignee: | Peter Lemenkov <lemenkov> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, lemenkov, negativo17, notting |
Target Milestone: | --- | Flags: | lemenkov:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 2.1.0-3.fc9 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-03-04 16:24:08 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Dominik 'Rathann' Mierzejewski
2009-02-04 01:12:57 UTC
I'll review it. Remarks: * No idea what is AVASYS Public License (rpmlint also shouts that it doesn't know what is it), however it looks like "Distributable, No Modifications Permitted". * I found that there are different versions of AVASYS Public License - dated as 2008-04-01 and as 2005-04.01. * There is also another one license, named LICENSE.EPSON.{en,ja}.txt. * Missing BR: udev ( rpm -qf /lib/firmware ) Ping, Dominik. (In reply to comment #2) > Remarks: > > * No idea what is AVASYS Public License (rpmlint also shouts that it doesn't > know what is it), however it looks like "Distributable, No Modifications > Permitted". Fixed. > * I found that there are different versions of AVASYS Public License - dated as > 2008-04-01 and as 2005-04.01. They're almost identical. The only change is s/EPSON AVASYS/AVASYS/g. Still, included. > * There is also another one license, named LICENSE.EPSON.{en,ja}.txt. Included. > * Missing BR: udev ( rpm -qf /lib/firmware ) It's not necessary for building, but indeed it should be required for installation to ensure that /lib/firmware is present before installation. http://rathann.fedorapeople.org/review/iscan-firmware.spec http://rathann.fedorapeople.org/review/iscan-firmware-2.16.0-2.fc9.src.rpm REVIEW: + rpmlint is silent + The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines . + The package is licensed with a Fedora approved license and meets the Licensing Guidelines . + The License field in the package spec file matches the actual license. + The file, containing the text of the license(s) for the package, is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package must match the upstream source, as provided in the spec URL. [petro@Sulaco SOURCES]$ md5sum `ls iscan-plugin-gt-*|sort` ed12335648c893eda194afee38e51351 iscan-plugin-gt-1500-2.1.0-2.c2.i386.rpm ed12335648c893eda194afee38e51351 iscan-plugin-gt-1500-2.1.0-2.c2.i386.rpm.from_srpm f76725766f44debe3f3fec06d0e2023b iscan-plugin-gt-9400-1.0.0-1.c2.i386.rpm f76725766f44debe3f3fec06d0e2023b iscan-plugin-gt-9400-1.0.0-1.c2.i386.rpm.from_srpm 8b1c398ef58769d9ceb77ad771515de3 iscan-plugin-gt-f500-1.0.0-1.c2.i386.rpm 8b1c398ef58769d9ceb77ad771515de3 iscan-plugin-gt-f500-1.0.0-1.c2.i386.rpm.from_srpm b72a512a927b9f2020af817c5a541ae8 iscan-plugin-gt-f520-1.0.0-1.c2.i386.rpm b72a512a927b9f2020af817c5a541ae8 iscan-plugin-gt-f520-1.0.0-1.c2.i386.rpm.from_srpm 5f4137fd69198617b95bd59261affd75 iscan-plugin-gt-f600-1.0.0-1.c2.i386.rpm 5f4137fd69198617b95bd59261affd75 iscan-plugin-gt-f600-1.0.0-1.c2.i386.rpm.from_srpm bb623b47fd457e94f8d6b878b5d9ad99 iscan-plugin-gt-f670-2.0.0-1.c2.i386.rpm bb623b47fd457e94f8d6b878b5d9ad99 iscan-plugin-gt-f670-2.0.0-1.c2.i386.rpm.from_srpm cf191e84b03b28a8b0f629d60ba0b36e iscan-plugin-gt-f700-2.0.0-0.c2.i386.rpm cf191e84b03b28a8b0f629d60ba0b36e iscan-plugin-gt-f700-2.0.0-0.c2.i386.rpm.from_srpm bda9d1dfe5c9524084b01e46a7a9f5e3 iscan-plugin-gt-s600-2.0.0-1.c2.i386.rpm bda9d1dfe5c9524084b01e46a7a9f5e3 iscan-plugin-gt-s600-2.0.0-1.c2.i386.rpm.from_srpm 02c151a49608ae911b1e200672ed236f iscan-plugin-gt-x750-1.0.0-1.c2.i386.rpm 02c151a49608ae911b1e200672ed236f iscan-plugin-gt-x750-1.0.0-1.c2.i386.rpm.from_srpm c33515ec3e57eed680cd599452141d45 iscan-plugin-gt-x770-2.1.0-1.c2.i386.rpm c33515ec3e57eed680cd599452141d45 iscan-plugin-gt-x770-2.1.0-1.c2.i386.rpm.from_srpm [petro@Sulaco SOURCES]$ + The package successfully compiles and builds into binary rpms on at least one primary architecture: http://koji.fedoraproject.org/koji/taskinfo?taskID=1210911 + No additional build dependencies. + The package owns all directories that it creates. + The package does not contain any duplicate files. + Permissions on files are set properly. + Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + The package consistently uses macros. + The package contains code, or permissible content. + No large documentation files. + Everything, the package includes as %doc, does not affect the runtime of the application. + No header files. + No static libraries. + No pkgconfig(.pc) files. + No libraries files with a suffix. + No .la libtool archives. + Not a GUI application. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [25] + All filenames in the package are valid UTF-8. This package is APPROVED New Package CVS Request ======================= Package Name: iscan-firmware Short Description: Firmware for Epson flatbed scanners Owners: rathann Branches: F-9 F-10 InitialCC: cvs done. iscan-firmware-2.1.0-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/iscan-firmware-2.1.0-3.fc10 iscan-firmware-2.1.0-3.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/iscan-firmware-2.1.0-3.fc9 iscan-firmware-2.1.0-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. iscan-firmware-2.1.0-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: iscan-firmware New Branches: el6 epel7 Owners: slaanesh Git done (by process-git-requests). |