Bug 484091

Summary: Incorrect CFLAGS in libical.pc
Product: [Fedora] Fedora Reporter: Matthew Barnes <mbarnes>
Component: libicalAssignee: Debarshi Ray <debarshir>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: rdieter
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-02-17 05:11:31 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Proposed patch to fix CFLAGS in libical.pc.
none
Fix headers too none

Description Matthew Barnes 2009-02-04 18:03:36 UTC 
Evolution recently merged to upstream libical, but we're having to work around an issue in libical's pkg-config file.

#include <ical.h> gives you a deprecation warning and tells you to #include <libical/ical.h> instead.  But the CFLAGS provided by libical.pc don't support this:

   $pkg-config --cflags libical
   -I/usr/include/libical  

With this, #include <libical/ical.h> fails because there's no such file /usr/include/libical/libical/ical.h.

The CFLAGS should include "-I/usr/include".
Comment 1 Rex Dieter 2009-02-04 18:17:34 UTC 
pkg-config will never return /usr/include, since that's a default include dir.

(Not that I'm arguing against -I/usr/include/libical being wrong).
Comment 2 Debarshi Ray 2009-02-17 05:05:28 UTC 
Created attachment 332171 [details]
Proposed patch to fix CFLAGS in libical.pc.
Comment 3 Fedora Update System 2009-03-13 18:37:26 UTC 
libical-0.43-2.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 4 Fedora Update System 2009-03-13 18:43:02 UTC 
libical-0.43-2.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 5 Debarshi Ray 2009-03-15 17:36:16 UTC 
Created attachment 335265 [details]
Fix headers too

We also need to fix some of the #includes in libical-devel to make things work with our CFLAGS.
Comment 6 Fedora Update System 2009-03-15 19:10:42 UTC 
libical-0.43-4.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/libical-0.43-4.fc10
Comment 7 Fedora Update System 2009-03-15 19:13:38 UTC 
libical-0.43-4.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/libical-0.43-4.fc9
Comment 8 Fedora Update System 2009-03-25 16:02:03 UTC 
libical-0.43-4.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 9 Fedora Update System 2009-03-25 16:14:36 UTC 
libical-0.43-4.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.