Bug 484137

Summary:	Certain actions contain member variables
Product:	Red Hat Satellite 5	Reporter:	Justin Sherrill <jsherril>
Component:	WebUI	Assignee:	Justin Sherrill <jsherril>
Status:	CLOSED CURRENTRELEASE	QA Contact:	John Matthews <jmatthew>
Severity:	medium	Docs Contact:
Priority:	low
Version:	530	CC:	cperry, jbrownin
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	sat530	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-09-10 20:32:42 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	456985

Description Justin Sherrill 2009-02-04 23:05:40 UTC

Certain of our Action classes contain non-final member variables which is not safe in most cases.  I've changed the classes that had mistakes but the following pages/actions should have some basic sanity testing done to make sure the changes didnt' affect anything:

Logging Out
YourRHN 
Popular Channel List
SSM channel subscribe
/rhn/admin/config/GeneralConfig.do
Virtualization Entitlements



I've tested all of these and they seem fine.

Comment 1 Justin Sherrill 2009-02-04 23:06:41 UTC

Also, just FYI, I wrote a doclet that scans our Actions, so this shouldn't be a problem going forward.

Comment 2 Clifford Perry 2009-02-05 16:31:17 UTC

Justin - commit code - move to modified - list specific URL's pages for QA to review. 

Thanks,
Cliff

Comment 3 Justin Sherrill 2009-02-05 17:45:51 UTC

/rhn/Logout.do
/rhn/YourRhn.do
/rhn/software/channels/Popular.do
/rhn/channel/ssm/BaseChannelSubscribe.do
/rhn/admin/config/GeneralConfig.do
/rhn/systems/entitlements/GuestLimitedHosts.do

Comment 4 John Matthews 2009-03-24 21:03:57 UTC

Verified
ISO: Satellite-5.3.0-RHEL5-re20090323.0-i386-embedded-oracle.iso

Comment 5 Jeff Browning 2009-08-27 06:44:55 UTC

Tested on dhcp77-153.rhndev.redhat.com

Comment 6 Brandon Perkins 2009-09-10 20:32:42 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHEA-2009-1434.html