Bug 484415

Summary: CCISS device-mapper-multipath support: missing sysfs attributes
Product: Red Hat Enterprise Linux 4 Reporter: Bryn M. Reeves <bmr>
Component: kernelAssignee: Tomas Henzl <thenzl>
Status: CLOSED ERRATA QA Contact: Barry Donahue <bdonahue>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 4.9CC: bmarzins, bubrown, bzeranski, coughlan, dhoward, emcnabb, fge, kris.strecker, lsmid, mike.miller, mtian, sandy.garza, tao, thenzl
Target Milestone: rcKeywords: Reopened, ZStream
Target Release: 4.9   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
CCISS devices are now supported.
Story Points: ---
Clone Of:
: 484419 (view as bug list) Environment:
Last Closed: 2011-02-16 15:23:52 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 484419, 519093    
Bug Blocks: 499024, 529309    
Attachments:
Description Flags
Patch to export bus attribute to sysfs none

Description Bryn M. Reeves 2009-02-06 17:33:33 UTC
Description of problem:
The multipath-tools components rely on being able to retrieve vendor/product information from sysfs in order to match storage controllers to their configurations.

The CCISS driver does not export these attributes.

Version-Release number of selected component (if applicable):
All RHEL4 kernels.

How reproducible:
100%

Steps to Reproduce:
1. Install device-mapper-multipath on a system with dual CCISS controllers
2. Attempt to configure multipath maps (e.g multipath -v3)

  
Actual results:
# multipath -v6
load path identifiers cache
#
# all paths in cache :
#
path cciss!c0d0 not found in pathvec

===== path info cciss!c0d0 (mask 0x1f) =====
path cciss!c1d0 not found in pathvec

===== path info cciss!c1d0 (mask 0x1f) =====
path cciss!c1d1 not found in pathvec

===== path info cciss!c1d1 (mask 0x1f) =====
path cciss!c2d0 not found in pathvec

===== path info cciss!c2d0 (mask 0x1f) =====
path cciss!c2d1 not found in pathvec

===== path info cciss!c2d1 (mask 0x1f) =====

Expected results:
Multipath maps detected and configured.

Additional info:
CCISS upstream does not support these attributes either. Patches adding them were posted twice to LKML back in 2007. On the first post a number of problems were pointed out but the repost addressing these does not appear to have gone anywhere:

http://lkml.indiana.edu/hypermail/linux/kernel/0711.2/1026.html
http://lkml.indiana.edu/hypermail/linux/kernel/0712.1/2724.html

Comment 2 Tomas Henzl 2009-04-03 14:58:58 UTC
This has been solved in 'cciss updates needed for RHEL 4.8'.
I'm closing this as duplicate.

*** This bug has been marked as a duplicate of bug 490187 ***

Comment 3 Ben Marzinski 2009-04-29 01:37:16 UTC
I'm reopening this since multipath needs to be able to get the cciss bus sysfs attribute which is exported via cciss_show_bus() in the lkml patch Bryn referenced.  If this is impossible to do in RHEL4, multipath can work around it. But for the multipath code to work as it is now, the bus attribute is necessary.

Comment 4 Tomas Henzl 2009-04-29 09:04:25 UTC
Ben,
thanks for helping us with the multipath issue.

I thinks we are sure too late for RHEL4.8, and I'm not sure if this will qualify for RHEL4.9.
Is multipath somehow limited in function without the bus attribute or not ?

We've a simmillar issue in RHEL5, so we can add the missing attribute at least there and close this one as WONTFIX.

Comment 5 Tomas Henzl 2009-05-04 14:59:55 UTC
*** Bug 498880 has been marked as a duplicate of this bug. ***

Comment 6 Tomas Henzl 2009-05-04 15:03:29 UTC
Created attachment 342323 [details]
Patch to export bus attribute to sysfs

Patch copied from bz#490187
Patch to export bus attribute to sysfs

Comment 7 RHEL Program Management 2009-06-05 13:47:15 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 9 Mike Miller (OS Dev) 2009-09-14 18:33:21 UTC
Tomas, was the bus attribute all that was needed to resolve this issue? Or are others needed, also. We're trying to limit rhel4 to bug fixes only.

-- mikem

Comment 13 Tomas Henzl 2009-10-02 13:53:50 UTC
(In reply to comment #9)
> Tomas, was the bus attribute all that was needed to resolve this issue? Or are
> others needed, also. We're trying to limit rhel4 to bug fixes only.
> 
> -- mikem  

Thanks, from the test I hope this was the last attribute needed.

Posted today on rhkl.

Comment 17 Ronald Pacheco 2009-10-30 00:21:49 UTC
Mike,

Can you provide an ETA for when this patch will be submitted upstream?  Upstream posting is holding up the delivery of a final resolution to the customers waiting for this.

Thanks and Regards,

Ron

Comment 18 Vivek Goyal 2009-10-30 18:04:54 UTC
Committed in 89.14.EL . RPMS are available at http://people.redhat.com/vgoyal/rhel4/

Comment 19 Mike Miller (OS Dev) 2009-11-02 17:23:25 UTC
A patch is already upstream that exports the bus attribute. Please see:

http://patchwork.kernel.org/patch/26781/

This patch assigns a cciss bus_type which I think does the same thing as the patch from Tomas.

Comment 20 Mike Miller (OS Dev) 2009-12-08 16:32:02 UTC
>> Tomas, was the bus attribute all that was needed to resolve this issue? Or are
>> others needed, also. We're trying to limit rhel4 to bug fixes only.
>>
>> -- mikem  
>
> Thanks, from the test I hope this was the last attribute needed.
>
> Posted today on rhkl.
-------
Where are we on this?

Comment 21 Tomas Henzl 2009-12-08 17:29:22 UTC
(In reply to comment #20)
> >> Tomas, was the bus attribute all that was needed to resolve this issue? Or are
> >> others needed, also. We're trying to limit rhel4 to bug fixes only.
> >>
> >> -- mikem  
> >
> > Thanks, from the test I hope this was the last attribute needed.
> >
> > Posted today on rhkl.
> -------
> Where are we on this?  
The patch posted here is committed in 89.14.EL - Comment#18

But your patch http://patchwork.kernel.org/patch/26781/
doesn't contain this - look for cciss_show_bus, this function is not in the patch you mentioned.

Comment 24 Vivek Goyal 2010-10-18 21:28:26 UTC
Some errors/confusions while adding the bz to errata tool. Returning bz to MODIFIED state so that it can be added to errata.

Comment 26 Eva Kopalova 2010-11-30 12:00:43 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
CCISS devices are now supported.

Comment 27 Brenda Tian 2011-01-26 07:59:37 UTC
Through code review, confirmed the patch included into
 kernel-2.6.9-97.EL, marked SanityOnly.

Comment 28 errata-xmlrpc 2011-02-16 15:23:52 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0263.html