Bug 484476

Summary:	Review Request: telepathy-farsight - Telepathy client to handle media streaming channels
Product:	[Fedora] Fedora	Reporter:	Brian Pepple <bdpepple>
Component:	Package Review	Assignee:	Jeremy Katz <katzj>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting
Target Milestone:	---	Flags:	katzj: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-02-11 00:10:26 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Brian Pepple 2009-02-07 00:29:18 UTC

Spec URL: http://bpepple.fedorapeople.org/rpms/telepathy-farsight.spec
SRPM URL: http://bpepple.fedorapeople.org/rpms/telepathy-farsight-0.0.4-1.fc10.src.rpm
Description: telepathy-farsight is a Telepathy client that uses Farsight and GStreamer to handle media streaming channels. It's used as a background process
by other Telepathy clients, rather than presenting any user interface
of its own.

Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=1110591

NOTE: This package is needed to build the latest version of Empathy in Rawhide, so a quick review would be most appreciated.  Thanks!

Comment 1 Jeremy Katz 2009-02-10 04:07:24 UTC

Spec file looks fine; I'm not a huge fan of macro-ifying versions, but that's purely a style question.  

rpmlint reports
telepathy-farsight.src: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 8)
telepathy-farsight-python.x86_64: W: no-documentation

The latter of which seems fine, the former should probably be fixed since it's trivial but I trust you'll do that on import

The only thing that really pops out at me is that /usr/include/telepathy-1.0 is owned by the telepathy-filesystem package.  Maybe just have -devel depend on that instead since it's going to be there for any real telepathy stack usage anyway? 

Also, have you contacted upstream about killing the rpath?  Although it looks like it might just be getting pulled in due to whatever version of autotools they've got rather than anything explicit

Comment 2 Brian Pepple 2009-02-10 15:08:25 UTC

Spec URL: http://bpepple.fedorapeople.org/rpms/telepathy-farsight.spec
SRPM URL:
http://bpepple.fedorapeople.org/rpms/telepathy-farsight-0.0.4-1.fc10.src.rpm

* Tue Feb 10 2009 Brian Pepple <bpepple> - 0.0.4-2
- Add devel requires on telepathy-filesystem.

Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=1117361

Comment 3 Brian Pepple 2009-02-10 15:09:22 UTC

Oops, forgot to mention that I haven't had a chance to talk to upstream about the rpath issue.

Comment 4 Jeremy Katz 2009-02-10 15:14:43 UTC

Probably worth doing, but certainly not a blocker for getting it in given the workaround present.  Approved.

Comment 5 Brian Pepple 2009-02-10 15:40:45 UTC

New Package CVS Request
=======================
Package Name: telepathy-farsight
Short Description: telepathy client to handle media streaming channels 
Owners: bpepple
Branches: 
InitialCC:

Comment 6 Kevin Fenzi 2009-02-10 22:16:24 UTC

cvs done.

Comment 7 Brian Pepple 2009-02-11 00:10:26 UTC

Jeremy, thanks for the review.  I really appreciate it.

Package imported & built for Rawhide.