Bug 484507
| Summary: | Review Request: php-channel-ezc - eZ Components | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Guillaume Kulakowski <guillaume> |
| Component: | Package Review | Assignee: | Remi Collet <fedora> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | 10 | CC: | fedora, fedora-package-review, notting, pahan |
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | noarch | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1-1.fc9 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-03-04 16:21:47 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 484509, 484563, 484567, 490591, 490592, 490849, 490851 | ||
|
Description
Guillaume Kulakowski
2009-02-07 16:17:22 UTC
REVIEW
* no source files
* package meets naming and packaging guidelines (recently approved new PHP Guidelines).
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license (of the packages provided by the channel).
* license is open source-compatible (BSD).
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide).
* package installs properly
* rpmlint :
php-channel-ezc.src:21: W: unversioned-explicit-provides php-channel(ezc)
php-channel-ezc.src:22: W: unversioned-explicit-provides php-channel(%{channel})
* final provides are sane:
php-channel(components.ez.no)
php-channel(ezc)
php-channel-ezc = 1-1.fc8
* %check is not present; no test suite provide.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (pear channel..)
* no documentation
No version for the .xml file, but I think using 1 is OK.
Providing php-channel(ezc) is not usefull and should be removed.
APPROVED
New Package CVS Request ======================= Package Name: php-channel-ezc Short Description: Adds eZ Components channel to PEAR Owners: llaumgui Branches: F-9 F-10 InitialCC: cvs done. php-channel-ezc-1-1.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update php-channel-ezc'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-1948 php-channel-ezc-1-1.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update php-channel-ezc'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-2012 php-channel-ezc-1-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. php-channel-ezc-1-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: php-channel-ezc New Branches: EL-6 Owners: llaumgui Git done (by process-git-requests). |