Bug 484511
Summary: | Review Request: crunchyfrog - A multi-engine SQL client and database front-end | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ignacio Vazquez-Abrams <ivazqueznet> |
Component: | Package Review | Assignee: | Rakesh Pandit <rpandit> |
Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | dmalcolm, fedora-package-review, mail, notting, pahan, rpandit |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-08-18 02:07:52 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Ignacio Vazquez-Abrams
2009-02-07 16:51:08 UTC
Does this actually build for you? On running: $ rpmbuild --rebuild crunchyfrog-0.3.3-1.src.rpm I get: + unset DISPLAY + /usr/bin/python setup.py build Traceback (most recent call last): File "setup.py", line 41, in <module> from cf import release File "/home/david/rpmbuild/BUILD/crunchyfrog-0.3.3/cf/__init__.py", line 78, in <module> import gtk File "/usr/lib/python2.5/site-packages/gtk-2.0/gtk/__init__.py", line 79, in <module> _init() File "/usr/lib/python2.5/site-packages/gtk-2.0/gtk/__init__.py", line 67, in _init _gtk.init_check() RuntimeError: could not open display error: Bad exit status from /var/tmp/rpm-tmp.8x83EX (%build) Looks like the error is from crunchyfrog-0.3.3/cf/__init__.py: try: import gtk import gtk.glade gtk.glade.textdomain('crunchyfrog') gtk.glade.bindtextdomain('crunchyfrog', LOCALE_DIR) except ImportError: # We don't need it on buildbots, so let's die silently. pass and this is raising a RuntimeError, not an ImportError This is on F10, not rawhide: pygtk2-2.13.0-2.fc10.i386 I got it to build on my F10 laptop by patching the file above. See http://people.redhat.com/dmalcolm/crunchyfrog-0.3.3-1.fc10.src.rpm Not a real review yet, but on superficial inspection: - rpmlint is clean - need to add: Requires: ipython Might be nice to patch the plugins window so that it uses PackageKit to install missing RPMs for the various db backends. Probably something to take upstream Aha: there's nothing in the BuildRequires that brings in pygtk2, so on a clean build root, the build succeeds (due to the "except: ImportError"), whereas on a machine with pygtk2 it failes. So my patch is wrong as is. Updated. http://ivazquez.fedorapeople.org/packages/crunchyfrog/crunchyfrog.spec http://ivazquez.fedorapeople.org/packages/crunchyfrog/crunchyfrog-0.3.4-1.src.rpm Nice .... you are already put up a review ... I also spent some time .. in packaging it .. and later found a review already there. Here is my SPEC and SRPM .. in case it is of any help. http://rakesh.fedorapeople.org/spec/crunchyfrog.spec http://rakesh.fedorapeople.org/srpm/crunchyfrog-0.3.4-1.fc10.src.rpm Thanks, Will review http://ivazquez.fedorapeople.org/packages/crunchyfrog/crunchyfrog.spec http://ivazquez.fedorapeople.org/packages/crunchyfrog/crunchyfrog-0.3.4-1.src.rpm I am reviewing ivazquez's files: 1. Why is %{dist} missing from srpm ? 2. License snippet from code says "# the Free Software Foundation, either version 3 of the License, or # (at your option) any later version. " that means GPLv3+ 3. may you check http://fedoraproject.org/wiki/Packaging/ScriptletSnippets & http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files for icon also you need hicolor-* dependency .. may you check the spec file in #8 Thanks, May you check missing requires and buildrequires build fails: http://koji.fedoraproject.org/koji/taskinfo?taskID=1433075 hi Ignacio, Are you still interested in carrying this review forward ? hi Ignacio, I will post a new review request and close this in case I don't see any response in a week. Thanks, Yes, sorry, please do. Feel free to use my work. *** This bug has been marked as a duplicate of bug 526451 *** |