Bug 484598
| Summary: | Review Request: grin - Grep-like tool for source code | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Terje Røsten <terje.rosten> |
| Component: | Package Review | Assignee: | Marcela Mašláňová <mmaslano> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, pahan |
| Target Milestone: | --- | Flags: | mmaslano:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | grin-1.1.1-3.el5 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-03-03 22:03:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 484597 | ||
| Bug Blocks: | |||
|
Description
Terje Røsten
2009-02-08 21:12:43 UTC
OK source files match upstream 9dca5a5876938adfd9dfc20869818660 OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license. OK BSD license is open source-compatible. License text not included upstream. OK latest version is being packaged. OK BuildRequires are proper. OK %clean is present. OK package builds in mock (Rawhide/x86_64). OK debuginfo package isn't need. FAIL rpmlint is silent. OK final provides and requires look sane. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. I run also test, which failed probably because I don't have nose installed? grin.noarch: W: no-documentation grin.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/grin.py 0644 - add docs - rpmlint clean - add %%check section spec: http://terjeros.fedorapeople.org/grin/grin.spec srpm: http://terjeros.fedorapeople.org/grin/grin-1.1.1-2.fc10.src.rpm koji: n/a (koji server down this weekend) Thanks Marcela! New Package CVS Request ======================= Package Name: grin Short Description: Grep-like tool for source code Owners: terjeros Branches: F-9 F-10 InitialCC: cvs done. Imported, built and pushed to bodhi. Please, can you maintain it for EPEL5 too? If it not so hard... Sorry for the late reply. At the moment I don't maintain any package for EPEL, sorry. I built it on El5 and El6 it seams no problem there. If you do not argue, I can co-maintain it for epel. Great, thanks! Package Change Request ====================== Package Name: grin New Branches: EL-4 EL-5 Owners: hubbitus cvs done. Would you also like a EL-6 branch? Sorry, it is my error. Instead EL-4 should be EL-6! I do not think it is possible (at least is not so easy) import for EL-4 because some python dependencies like python-argparse. Package Change Request ====================== Package Name: grin New Branches: EL-6 Delete Branches: EL-4 Owners: hubbitus If delete branch is impossible, just ignore it, and I ignore it also. Again sorry for the mistake. We cannot delete branches. I have created the EL-6 branch. Thank you. And sorry for the error. Updates follow. grin-1.1.1-3.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/grin-1.1.1-3.el5 Strange, on El6 build successfull, but update was not pushed with erorr: Creating a new update for grin-1.1.1-3.el6 hubbitus does not have commit access to grin grin-1.1.1-3.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |