Bug 485177

Summary: needinfo flag requstee is not set properly when changing multiple bugs
Product: [Community] Bugzilla Reporter: Noura El hawary <nelhawar>
Component: Creating/Changing BugsAssignee: David Lawrence <dkl>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 3.2CC: dkl, rlerch
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-02-16 16:19:37 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch to fix needinfo for mass editing of bugs (v1) nelhawar: review+

Description Noura El hawary 2009-02-12 04:58:37 UTC 
This problem was reported by Ryan Lerch, when trying to request the needinfo flag for multiple bugs from the assingee for example then what happens is that all bugs gets set needinfo flag from the first bug assignee in the list, I have verified this problem and it is coming from process_bug.cgi as it only handles changing needinfo flag for fist bug in the list/single bug.

submitting a patch for the fix soon.

Noura
Comment 1 David Lawrence 2009-02-13 21:29:48 UTC 
I will take this Noura.
Comment 2 David Lawrence 2009-02-13 22:40:15 UTC 
Created attachment 331881 [details]
Patch to fix needinfo for mass editing of bugs (v1)

Here is a patch that should fix the needinfo issue that was reported in this bug.

Basically as stated what was happening is that the cgi params for the needinfo flag and requestee were getting set to the assignee/reporter/qa_contact for the first bug in the list and so each bug got the same values. 

I moved the code inside the last loop that goes through each of the bug objects and after the roles have all had a chance to be changed so that the needinfo will go to the new values for assigned_to/reporter/qa_contact if they were changed.

Also by being inside the bug objects foreach loop, the cgi variables are overwritten each time with the new assigned_to/reporter/qa_contact values for that bug. Bugzilla::Flag->process() will pick up the new values each time through the loop.

I have tested this on bz-web2-test and seems to be working now.

Please review.
Dave
Comment 3 Noura El hawary 2009-02-15 23:54:14 UTC 
Comment on attachment 331881 [details]
Patch to fix needinfo for mass editing of bugs (v1)

looks good Dave, all my testings were fine.

Thanks,
Noura
Comment 4 David Lawrence 2009-02-16 16:19:37 UTC 
Thanks Noura. Committed to CVS and will be in the next update.

Dave