Bug 485345
Summary: | Cannot export VPN connection | ||
---|---|---|---|
Product: | Red Hat Enterprise Linux 5 | Reporter: | Dan Williams <dcbw> |
Component: | NetworkManager | Assignee: | Dan Williams <dcbw> |
Status: | CLOSED ERRATA | QA Contact: | desktop-bugs <desktop-bugs> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | 5.3 | CC: | cmeadors, dcbw, rlerch, vbenes, zcerza |
Target Milestone: | rc | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: |
NetworkManager did not export VPN configurations. When a user selected this function, NetworkManager would present an error message: "VPN setting invalid", even for a connection with valid settings. Network manager now exports VPN connections correctly.
|
Story Points: | --- |
Clone Of: | 480496 | Environment: | |
Last Closed: | 2009-09-02 11:54:14 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 480496 | ||
Bug Blocks: |
Description
Dan Williams
2009-02-12 23:54:24 UTC
Fix below; upstream SVN revisions 1156 (trunk) and 1157 (stable 0.7). Low risk. Index: src/connection-editor/vpn-helpers.c =================================================================== --- src/connection-editor/vpn-helpers.c (revision 1155) +++ src/connection-editor/vpn-helpers.c (working copy) @@ -326,10 +326,10 @@ export_vpn_to_file_cb (GtkWidget *dialog goto done; } - s_vpn = NM_SETTING_VPN (nm_connection_get_setting (connection, NM_TYPE_SETTING_VPN)); + s_vpn = (NMSettingVPN *) nm_connection_get_setting (connection, NM_TYPE_SETTING_VPN); service_type = s_vpn ? nm_setting_vpn_get_service_type (s_vpn) : NULL; - if (service_type) { + if (!service_type) { g_set_error (&error, 0, 0, "VPN setting invalid"); goto done; } nm-connection-editor-vpn-export-rh485345.patch Release note added. If any revisions are required, please set the "requires_release_notes" flag to "?" and edit the "Release Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. New Contents: NetworkManager did not export VPN configurations. When a user selected this function, NetworkManager would present an error message: "VPN setting invalid", even for a connection with valid settings. Network manager now exports VPN connections correctly. Verified on NetworkManager-0.7.0-7.el5.{i386,x86_64}. An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2009-1389.html |