Bug 485403 (ytnef)
| Summary: | Review Request: ytnef - Yerase's TNEF Stream Reader. | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Itamar Reis Peixoto <itamar> |
| Component: | Package Review | Assignee: | Ray Van Dolson <rayvd> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | allisson, fedora-package-review, notting, rayvd |
| Target Milestone: | --- | Flags: | rayvd:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 2.6-4.fc10 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-09-09 01:51:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 485402 | ||
| Bug Blocks: | 485401 | ||
|
Description
Itamar Reis Peixoto
2009-02-13 12:19:19 UTC
koji scratch build in dist-f11 http://koji.fedoraproject.org/koji/taskinfo?taskID=1124686 Note that correct SRPM URL should be: http://ispbrasil.com.br/ytnef/ytnef-2.6-2.fc10.src.rpm At initial glance, can you change the license to GPLv2+?. Also, it's a little cleaner to use the %{__make}, %{__rm} macros if possible, and you might consider including ChangeLog as part of the documentation. I'll do a formal review tomorrow. Going to bed right now. :-) I am not clear about the license, I belive the correct license should be the same as already included libytnef-devel, GPL+ please l@@k new spec. http://ispbrasil.com.br/ytnef/ytnef.spec http://ispbrasil.com.br/ytnef/ytnef-2.6-3.fc11.src.rpm koji scratch build (dist-f11) ------------ http://koji.fedoraproject.org/koji/taskinfo?taskID=1256395 Sorry for the very long delay on this. :-( Going through the review I realized I can't even install this on Fedora 10: ytnef-2.6-3.fc10.i386 from ../RPMS/ytnef-2.6-3.fc10.i386.rpm has depsolving problems --> Missing Dependency: perl(Mail::Mailer::test) is needed by package ytnef-2.6-3.fc10.i386 (../RPMS/ytnef-2.6-3.fc10.i386.rpm) Error: Missing Dependency: perl(Mail::Mailer::test) is needed by package ytnef-2.6-3.fc10.i386 (../RPMS/ytnef-2.6-3.fc10.i386.rpm) (yum localinstall results). Maybe this package is provided by rawhide? I'll check. a yum provides on my F10 repos comes up with nothing however. (In reply to comment #4) please hold, I will check this soon. Any new information on this? look again http://ispbrasil.com.br/ytnef/ytnef.spec http://ispbrasil.com.br/ytnef/ytnef-2.6-4.fc11.src.rpm --- http://koji.fedoraproject.org/koji/taskinfo?taskID=1380867 ping My informal review: - Package build fine on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1612465 dist-f11 - Silent rpmlint output I think is all done with this package and should be approved :) Sorry guys, got super busy with work and have seriously neglected Fedora lately. I will do the formal review today. rpmlint output: ytnef.i586: I: checking1 packages and 0 specfiles checked; 0 errors, 0 warnings. MUST: The License field in the package spec file must match the actual license. -- Looks like the license string for this should be set to GPLv2+ not GPL+ All other MUST items check out. All SHOULD items check out. ACCEPTED New Package CVS Request ======================= Package Name: ytnef Short Description: Yerase's TNEF Stream Reader Owners: itamarjp Branches: F-10 F-11 InitialCC: CVS done. ytnef-2.6-4.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/ytnef-2.6-4.fc11 ytnef-2.6-4.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/ytnef-2.6-4.fc10 ytnef-2.6-4.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update ytnef'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-8853 ytnef-2.6-4.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update ytnef'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-8871 ytnef-2.6-4.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. ytnef-2.6-4.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |