Bug 485853

Summary:	Review Request: calendar - Reminder utility
Product:	[Fedora] Fedora	Reporter:	David Cantrell <dcantrell>
Component:	Package Review	Assignee:	Warren Togami <wtogami>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, tuju, wtogami
Target Milestone:	---	Flags:	wtogami: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://www.openbsd.org:80/cgi-bin/cvsweb/src/usr.bin/calendar/
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-02-20 21:02:11 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description David Cantrell 2009-02-17 02:48:38 UTC

Spec URL: http://dcantrel.fedorapeople.org/calendar.spec
SRPM URL: http://dcantrel.fedorapeople.org/calendar-1.25-1.src.rpm
Description: The OpenBSD calendar command is a reminder utility.  Calendar reads
a mix of configuration files and standard calendar databases and then displays lines that begin with either today's date or tomorrow's.  The output of the command shows upcoming events for the week.

Comment 1 David Cantrell 2009-02-17 20:37:14 UTC

Correction on SRPM URL:
http://dcantrel.fedorapeople.org/calendar-1.25-1.fc11.src.rpm

Comment 2 Warren Togami 2009-02-17 21:02:22 UTC

calendar.src: W: strange-permission export-calendar-source.sh 0775

export-calendar-source.sh to verify the source goes boom.

Comment 3 Warren Togami 2009-02-17 21:20:12 UTC

- RPM spec looks fine.
- export-calendar-source.sh fails for me, but manual comparison passes.
- My only concern is "calendar" might be too generic of a name.  Are you sure nothing else that could possibly be added to the distro has this name?  I approve this package if you ask fedora-devel-list for opinions and nobody objects within 24 hours of that posting.

Comment 4 David Cantrell 2009-02-17 21:48:20 UTC

Latest spec and source RPM:

http://dcantrel.fedorapeople.org/calendar.spec
http://dcantrel.fedorapeople.org/calendar-1.25-3.fc11.src.rpm

Comment 5 David Cantrell 2009-02-17 23:53:37 UTC

(In reply to comment #2)
> calendar.src: W: strange-permission export-calendar-source.sh 0775
> 
> export-calendar-source.sh to verify the source goes boom.

rpmlint seems to just dislike executable scripts in source RPM files.  I've changed this to 0644.

Comment 6 David Cantrell 2009-02-17 23:54:32 UTC

(In reply to comment #3)
> - export-calendar-source.sh fails for me, but manual comparison passes.

I've changed export-calendar-source.sh to use 'cvs status' to get the revision number of calendar.c.  That seemed to be failing on your system, but working on mine,

> - My only concern is "calendar" might be too generic of a name.  Are you sure
> nothing else that could possibly be added to the distro has this name?  I
> approve this package if you ask fedora-devel-list for opinions and nobody
> objects within 24 hours of that posting.

I will send a message to fedora-devel-list asking for comments.

Comment 7 Warren Togami 2009-02-20 02:06:01 UTC

APPROVED

Comment 8 David Cantrell 2009-02-20 02:11:55 UTC

New Package CVS Request
=======================
Package Name: calendar
Short Description: Reminder utility
Owners: dcantrel
Branches: F-9 F-10 EL-4 EL-5
InitialCC:

Comment 9 Kevin Fenzi 2009-02-20 19:44:54 UTC

cvs done.

Comment 10 David Cantrell 2014-06-27 14:56:46 UTC

Package Change Request
======================
Package Name: calendar
New Branches: epel7
Owners: dcantrel
InitialCC: 

Please create an EPEL-7 branch for calendar so I can make this package available to RHEL-7 users.

Comment 11 Gwyn Ciesla 2014-06-27 19:47:21 UTC

Git done (by process-git-requests).