Bug 486157

Summary: PV guest stops running when xm save fails
Product: Red Hat Enterprise Linux 5 Reporter: Jiri Denemark <jdenemar>
Component: xenAssignee: Jiri Denemark <jdenemar>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: low    
Version: 5.4CC: minovotn, mshao, pbonzini, syeghiay, xen-maint, yuzhang
Target Milestone: rcKeywords: Regression
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: xen-3.0.3-85.el5 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-09-02 10:09:20 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 484110    
Bug Blocks: 486291, 513335, 513537    
Attachments:
Description Flags
xend.log
none
Patch to fix this bug
none
xend.log none

Description Jiri Denemark 2009-02-18 17:26:35 UTC
Description of problem:

When xm save of a PV guest fails, the guest remains shut down.

Version-Release number of selected component (if applicable):

xen-3.0.3-80.el5

How reproducible:

always

Steps to Reproduce:

1. create a PV guest
2. xm save guest /mnt/small/guest.save
  
Actual results:

xm list shows
rhel5-64   2  511  1 ---s--      6.7

Expected results:

The guest should remain running as if no xm save command was ever issued

Additional info:

This is caused by xen-xenstore-permissions.patch. Both xen-3.0.3-80.el5 with this patch reverted and xen-3.0.3-64.el5 (RHEL 5.2) works almost fine (will file another BZ about this "almost" :-))

xend.log attachment will follow...

Comment 1 Jiri Denemark 2009-02-18 17:31:10 UTC
Created attachment 332424 [details]
xend.log

I almost forgot to attach the log...

Comment 2 RHEL Program Management 2009-02-18 18:04:22 UTC
This bugzilla has Keywords: Regression.  

Since no regressions are allowed between releases, 
it is also being proposed as a blocker for this release.  

Please resolve ASAP.

Comment 4 Jiri Denemark 2009-03-10 14:21:26 UTC
Created attachment 334662 [details]
Patch to fix this bug

Comment 5 Jiri Denemark 2009-03-10 14:22:29 UTC
The patch from rhbz #484110 is also required for fixing this issue...

Comment 7 Jiri Denemark 2009-05-11 13:40:39 UTC
Fix built into xen-3.0.3-85.el5

Comment 9 Yufang Zhang 2009-07-18 04:12:18 UTC
Reproducing the bug in a system updated to xen-3.0.3-90.el5,the guest still remains shutdown when save failed.

Release-Archs Covered:
  RHEL-5-Client - i386,x86_64
  RHEL-5-Server - i386,x86_64

Packages Tested:
  xen-3.0.3-90.el5
  xen-debuginfo-3.0.3-90.el5
  xen-devel-3.0.3-90.el5.i386
  xen-libs-3.0.3-90.el5.i386

Steps:
 (1)start a paravirtualized guest with 512MB memory
 (2)mount a 100MB disk partition on /mnt
 (3)run
     # xm save <guest> /mnt/<guest>.save
    then save will fail with:
     Error: /usr/lib/xen/bin/xc_save 22 5 0 0 0 failed
     Usage: xm save <Domain> <CheckpointFile>

     Save a domain state to restore later.
 (4)run
     #xm list
    shows:
     domain1 5 511 1 ---s-- 11.3
    the guest remains shutdown and can not run again.
                                                                        
xend.log is uploaded in the attachment.

Comment 10 Yufang Zhang 2009-07-18 04:17:34 UTC
Created attachment 354241 [details]
xend.log

Reproducing the bug in a system updated to xen-3.0.3-90.el5,the guest still remains shutdown when save failed.

Release-Archs Covered:
  RHEL-5-Client - i386,x86_64
  RHEL-5-Server - i386,x86_64

Packages Tested:
  xen-3.0.3-90.el5
  xen-debuginfo-3.0.3-90.el5
  xen-devel-3.0.3-90.el5.i386
  xen-libs-3.0.3-90.el5.i386

Steps:
 (1)start a paravirtualized guest with 512MB memory
 (2)mount a 100MB disk partition on /mnt
 (3)run
     # xm save <guest> /mnt/<guest>.save
    then save will fail with:
     Error: /usr/lib/xen/bin/xc_save 22 5 0 0 0 failed
     Usage: xm save <Domain> <CheckpointFile>

     Save a domain state to restore later.
 (4)run
     #xm list
    shows:
     domain1 5 511 1 ---s-- 11.3
    the guest remains shutdown and can not run again.
                                                                        
xend.log is uploaded in the attachment.

Comment 11 Michal Novotny 2009-07-20 07:51:59 UTC
I am afraid this was introduced by one of my patches regarding PVFB backend removal, I'll do some more investigation of this one but since there is an error with vkbd device I think this is the issue. I'll to further investigation of this one...

Michal

Comment 12 Michal Novotny 2009-07-20 12:47:16 UTC
Well, I have created new patch for BZ #507765 that should be solving this one. You can find new RPMs with this patch applied at:

http://people.redhat.com/minovotn/xen

Thanks,
Michal

Comment 13 Yufang Zhang 2009-07-21 12:40:54 UTC
May I ask When will the new RPMs get into ERRATA?

Comment 15 Jiri Denemark 2009-07-22 16:25:37 UTC
Oops, the error you saw was not caused by the patch for PVFB backend removal. So it won't be fixed in the next package. Please, verify this bug and https://bugzilla.redhat.com/show_bug.cgi?id=486291 with a PV guest without VFB device and report the error you saw as a new BZ.

Thanks.

Comment 16 Yufang Zhang 2009-07-23 03:55:04 UTC
32-bit PV guest on x86_64 host still remains shutdown when 'xm save' failed:

Packages Tested:
  xen-3.0.3-91.el5
  
Steps:
 (1)start a 32-bit paravirtualized guest with 512MB memory on x86_64 host
 (2)mount a 100MB disk partition on /mnt
 (3)run
     # xm save <guest> /mnt/<guest>.save
    then save will fail with:
     Error: /usr/lib/xen/bin/xc_save 22 5 0 0 0 failed
     Usage: xm save <Domain> <CheckpointFile>

     Save a domain state to restore later.
 (4)run
     #xm list
    shows:
     domain1 5 511 1 ---s-- 11.3
    the guest remains shutdown and can not run again.It is not connected by network too.


A 32-bit PV on 32-bit host works just fine when xm save failed,as if no xm save command was ever issued

Comment 17 Yufang Zhang 2009-07-23 03:59:42 UTC
Sorry, I forget to mention that the all PV guests are started without VFB device in the above certification process.

Comment 18 Jiri Denemark 2009-07-23 09:21:43 UTC
Oh man, another 32-on-64 bug... Luckily it is a small one. Could you please report it as a new bug with xend.log attached?

Thanks a lot.

Comment 19 Paolo Bonzini 2009-07-23 11:50:36 UTC
The new bug is 513335.

Comment 22 Yewei Shao 2009-07-28 08:07:38 UTC
Verified on xen-3.0.3-91.el5

Comment 24 errata-xmlrpc 2009-09-02 10:09:20 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2009-1328.html