Bug 486489

Summary:	Review Request: perl-Object-Event - Class that provides an event callback interface
Product:	[Fedora] Fedora	Reporter:	Allisson Azevedo <allisson>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, panemade, rc040203
Target Milestone:	---	Flags:	panemade: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-02-21 02:10:56 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Allisson Azevedo 2009-02-19 23:23:57 UTC

Spec URL: http://allisson.fedorapeople.org/packages/perl-Object-Event/perl-Object-Event.spec

SRPM URL: http://allisson.fedorapeople.org/packages/perl-Object-Event/perl-Object-Event-0.7-1.fc10.src.rpm

Description: This module was mainly written for Net::XMPP2, Net::IRC3, AnyEvent::HTTPD
and BS to provide a consistent API for registering and emitting events.
Even though I originally wrote it for those modules I released it
separately in case anyone may find this module useful.

Comment 1 Parag AN(पराग) 2009-02-20 04:30:06 UTC

Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1141380
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
a6d9daa3091d38a6cfe310100a00b897  Object-Event-0.7.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=9, Tests=54,  1 wallclock secs ( 0.04 usr  0.01 sys +  0.36 cusr  0.03 csys =  0.44 CPU)
+ Package perl-Object-Event-0.7-1.fc11 =>
Provides: perl(Object::Event) = 0.7 perl(Object::Event::Methods)
Requires: perl(Scalar::Util) perl(base) perl(strict)

APPROVED.

Comment 2 Allisson Azevedo 2009-02-20 10:30:35 UTC

New Package CVS Request
=======================
Package Name: perl-Object-Event
Short Description: Class that provides an event callback interface
Owners: allisson
Branches: F-9 F-10

Comment 3 Ralf Corsepius 2009-02-20 11:33:06 UTC

Please add InitialCC: perl-sig

Comment 4 Allisson Azevedo 2009-02-20 12:26:31 UTC

New Package CVS Request
=======================
Package Name: perl-Object-Event
Short Description: Class that provides an event callback interface
Owners: allisson
Branches: F-9 F-10
InitialCC: perl-sig

Comment 5 Kevin Fenzi 2009-02-20 20:21:02 UTC

cvs done.