Bug 486511
| Summary: | ppc: usb: rawhide kernel fails to enumerate USB | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tony Breeds <tony> |
| Component: | kernel | Assignee: | Kernel Maintainer List <kernel-maint> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ak, jwboyer, kernel-maint, kmcmartin, quintela |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | ppc | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-03-10 18:05:11 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Attachments: | |||
|
Description
Tony Breeds
2009-02-20 04:04:22 UTC
Created attachment 332667 [details]
dmesg from 2.6.29-0.131.rc5.git2.fc11.ppc
Created attachment 332668 [details]
dmesg from 2.6.29-rc5
Tony, can you poke at this a bit and see which patch (or config option) in rawhide seems to introduce the problem? I have no working ppc32 machine at the moment. Sure. My MacMini is a little slow but I'll get there. Sorry :/ we're just not currently patching this in any way in rawhide, so it's either an issue with a config setting, or an upstream issue as well. Possibly there's other reports of this on linuxppc-dev, or is ppc32 pretty well abandoned as far as top of tree testing goes? I see there's a ton of patches that come with the rawhide kernel's src.rpm or did you mean something else? Might be one of them... (In reply to comment #5) > Sorry :/ we're just not currently patching this in any way in rawhide, so it's > either an issue with a config setting, or an upstream issue as well. Possibly > there's other reports of this on linuxppc-dev, or is ppc32 pretty well > abandoned as far as top of tree testing goes? There aren't reports of it on linuxppc-dev. At least not in the past two months or so. ppc32 testing from a kernel aspect is mostly limited to embedded boards that Fedora doesn't support anyway. (In reply to comment #5) > Sorry :/ we're just not currently patching this in any way in rawhide, so it's > either an issue with a config setting, or an upstream issue as well. Possibly > there's other reports of this on linuxppc-dev, or is ppc32 pretty well > abandoned as far as top of tree testing goes? I tested -rc5 from upstream and the problem isn't there, so it's either a Fedora patch or a config setting. I'm trying to track down which it is. Created attachment 333664 [details]
one of these changes seem to cause the problem
I've done a few kernel builds using config files from F10 2.6.27 kernel, and I think I've narrowed the problem down to changes in config-powerpc-generic file. (see attachment for the patch). If you take the rawhide kernel and revert those changes, the problem should be gone - please verify.
Options that introduce new modules are probably not involved, and of the remaining options
+CONFIG_RELOCATABLE=y
+CONFIG_SIMPLE_GPIO=y
seem highly suspicious to my uneducated eye.
Anyway I'd like some hints about how to bisect this further (and how to do incremental kernel builds using src.rpm because a build from scratch takes 3 hours on my powerbook).
Given we're basically patching nothing that would effect this, the easiest way to find the broken option would be to just 'make prep' on rawhide and copy the resulting config file to .config and build it locally and disable/enable the options that way. You can at least (generally) reduce build time (and turn off piles of unrelated things like network drivers which wouldn't be causing this.) regards, Kyle (In reply to comment #9) > Created an attachment (id=333664) [details] > one of these changes seem to cause the problem > > I've done a few kernel builds using config files from F10 2.6.27 kernel, and I > think I've narrowed the problem down to changes in config-powerpc-generic file. > (see attachment for the patch). If you take the rawhide kernel and revert those > changes, the problem should be gone - please verify. > > Options that introduce new modules are probably not involved, and of the > remaining options > +CONFIG_RELOCATABLE=y > +CONFIG_SIMPLE_GPIO=y > seem highly suspicious to my uneducated eye. CONFIG_RELOCATABLE=y should actually get disabled entirely in the final .config file that is generated due to Kbuild dependencies. It's generally only enabled for ppc64 kernels. (In reply to comment #8) > (In reply to comment #5) > > Sorry :/ we're just not currently patching this in any way in rawhide, so it's > > either an issue with a config setting, or an upstream issue as well. Possibly > > there's other reports of this on linuxppc-dev, or is ppc32 pretty well > > abandoned as far as top of tree testing goes? > > I tested -rc5 from upstream and the problem isn't there, so it's either a > Fedora patch or a config setting. I'm trying to track down which it is. The problem seems to be "CONFIG_GEF_SBC610", turning that off in an otherwise unchanged fedora kernel results in a functioning USB stack on my Mac Mini. I'm doing a scratch build now of kernel-2.6.29-0.193.rc6.git7, with a patched config-powerpc-generic. Assuming this works, can we get that removed from the fedora config while we talk with upstream to work out why it's a problem? Created attachment 333953 [details]
Trivial patch to disable CONFIG_GEF_SBC610
(In reply to comment #12) > The problem seems to be "CONFIG_GEF_SBC610", turning that off in an otherwise > unchanged fedora kernel results in a functioning USB stack on my Mac Mini. > > I'm doing a scratch build now of kernel-2.6.29-0.193.rc6.git7, with a patched > config-powerpc-generic. Assuming this works, can we get that removed from the > fedora config while we talk with upstream to work out why it's a problem? Disabled. I'm thinking it was upstream commit a969e76a7101bf5f3d369563df1ca1253dd6131b that causes the problem:
commit a969e76a7101bf5f3d369563df1ca1253dd6131b
Author: Martyn Welch <martyn.welch>
Date: Mon Sep 29 13:35:15 2008 +0100
powerpc: Correct USB support for GE Fanuc SBC610
Support for the SBC610 VPX Single Board Computer from GE Fanuc (PowerPC
MPC8641D).
Fixup to correctly reconfigure USB, provided by an NEC uPD720101, after
device is reset. This requires a set of chip specific registers in the
devices configuration space to be correctly written, enabling all ports
and switching the device to use an external 48-MHz Oscillator.
Signed-off-by: Martyn Welch <martyn.welch>
Signed-off-by: Kumar Gala <galak.org>
Looks like it, it should be checking the subvendor/subdevice ids at the very least. Sigh. Broken code ftl. How about? Created attachment 333960 [details]
detect sbc610 boards
meh.
Created attachment 333966 [details]
Trivial patch to disable CONFIG_GEF_SBC610 v2
Apparently it wasn't as "trivial" as I thought. This one builds.
|