Bug 486595

Summary:	condor_configuration_node input validation
Product:	Red Hat Enterprise MRG	Reporter:	Martin Kudlej <mkudlej>
Component:	grid	Assignee:	Robert Rati <rrati>
Status:	CLOSED ERRATA	QA Contact:	Lubos Trilety <ltrilety>
Severity:	low	Docs Contact:
Priority:	low
Version:	1.1	CC:	ltrilety, matt
Target Milestone:	1.3
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Previously, there was no input validation of variables in the 'condor_configuration_node' function. With this update, all variables are validated.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-10-14 15:58:20 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Martin Kudlej 2009-02-20 14:58:06 UTC

Description of problem: 
There isn't any input validation in condor_configuration_node.

Actual results:
It is possible to set all variable to text, for example port number, IP.

Expected results:
Validation of all non-textual variables.

Additional info:
condor-remote-configuration-server-1.0-14.el5

Comment 1 Robert Rati 2010-02-23 21:11:23 UTC

All non-string params are not verified to be valid.

Fixed in:
condor-qmf-config-tools-2.1-0.1

Comment 2 Martin Kudlej 2010-04-29 14:29:16 UTC

Which ones are verified to be valid?

Comment 3 Robert Rati 2010-05-12 15:15:57 UTC

In the latest build (2.7-1):
All prompted params specific to VMUniverse
QMF Broker port
Broker port specified with -o

Comment 4 Lubos Trilety 2010-08-17 13:19:59 UTC

Tested with (version):
condor-wallaby-tools-3.0-1

Notes:
The original tool is no longer available the problem was tested with the actual tools - condor_configure_store/pool. It was only tested command line inputs such as qmf port number. Other inputs are tested are covered by bug 613595. 
For testing of wallaby-utils command tools see bug 613666.

Tested on:
RHEL5 i386,x86_64  - passed

>>> VERIFIED

Comment 5 Martin Prpič 2010-10-06 12:49:56 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Previously, there was no input validation of variables in the 'condor_configuration_node' function. With this update, all variables are validated.

Comment 7 errata-xmlrpc 2010-10-14 15:58:20 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2010-0773.html