Bug 486686

Summary: Review Request: tkgate - Digital Circuit Simulator
Product: [Fedora] Fedora Reporter: Thibault North <thibault.north>
Component: Package ReviewAssignee: Chitlesh GOORAH <chitlesh>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: chitlesh, fedora-package-review, notting
Target Milestone: ---Flags: chitlesh: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-03-21 11:35:24 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Thibault North 2009-02-21 00:37:56 UTC
Spec URL: http://tnorth.fedorapeople.org/FEL/tkgate.spec
SRPM URL: http://tnorth.fedorapeople.org/FEL/tkgate-2.0-2.beta6.fc11.src.rpm
Description: 
TkGate is a event driven digital circuit simulator based on Verilog . TkGate supports a wide range of primitive circuit elements as well as user-defined modules for hierarchical design.

Comment 1 Chitlesh GOORAH 2009-02-23 18:41:57 UTC
chitlesh(~)[0]$tkgate                                                                                          

I could not locate the tkgate home directory.  I tried looking in:
  /home/chitlesh  (current directory)                             
  /usr/share/tkgate  (primary location)                           
  /home/chitlesh/rpmbuild/BUILD/tkgate-2.0-b6  (secondary location)

Try setting the environment variable TKGATE_HOME.



-------------------

Can you fix this please before I start the review ?

Comment 2 Thibault North 2009-03-05 14:32:06 UTC
Thanks for the feedback. There is a new beta available, so it is now updated[1], and works for me.
Could you check again please ?

[1]SRPM URL: http://tnorth.fedorapeople.org/FEL/tkgate-2.0-1.beta7.fc11.src.rpm
[2]RPM i586: http://tnorth.fedorapeople.org/FEL/tkgate-2.0-1.beta7.fc11.i586.rpm

Comment 3 Thibault North 2009-03-05 18:55:20 UTC
There was indeed a bug with the file site-preferences moved as a document. Now creates and empty file %{_datadir}/%{name}/site-preferences, that's what tkgate wants to find its home directory.

SRPM and RPM have been updated, same address than above.

Comment 4 Chitlesh GOORAH 2009-03-05 21:49:41 UTC
I can't extract from the SRPM:

error: unpacking of archive failed on file /home/chitlesh/rpmbuild/SOURCES/tkgate-2.0-b7.tar.gz;49b04880: cpio: MD5 sum mismatch

Upload it again

Comment 5 Thibault North 2009-03-05 23:18:01 UTC
Humm problems using fedorapeople.org.

New srpm :
http://tnorth.ch/tkgate-2.0-4.beta7.fc11.src.rpm

Comment 6 Chitlesh GOORAH 2009-03-06 19:39:24 UTC
A few minor fixes are required before the commit:
- add a -p to the cp
- update the desktop file to the one below as it improves its menu entry on kde
cat > %{name}.desktop << EOF
[Desktop Entry]
Encoding=UTF-8
Name=Digital circuit simulator
GenericName=Verilog circuit simulator
Comment=Digital circuit simulator
Type=Application
Exec=tkgate
Icon=tkgate
Categories=Engineering;Electronics;
EOF

Package Approved

Comment 7 Thibault North 2009-03-06 23:18:03 UTC
Fixes have been applied.

http://tnorth.ch/tkgate-2.0-5.beta7.fc11.src.rpm

Koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1227946

Thanks.

Comment 8 Chitlesh GOORAH 2009-03-07 09:48:20 UTC
Please follow this wiki page
http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure
when requesting CVS branches.

Comment 9 Thibault North 2009-03-07 16:58:19 UTC
New Package CVS Request
=======================
Package Name: tkgate
Short Description: Digital Circuit Simulator
Owners: tnorth
Branches: F-9 F-10 EL-5
InitialCC: chitlesh

Comment 10 Kevin Fenzi 2009-03-07 17:08:03 UTC
cvs done.

Comment 11 Chitlesh GOORAH 2009-03-21 11:35:24 UTC
Already pushed in stable repos.