Bug 486949
| Summary: | PATCH: Fix tk applications crashing with libX11-1.2 update | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Hans de Goede <hdegoede> | ||||
| Component: | tk | Assignee: | Marcela Mašláňová <mmaslano> | ||||
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | rawhide | CC: | mmaslano | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2009-02-23 13:35:26 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
I reported bug to upstream so I'm also aware of the patch. The only problem now is koji. *** This bug has been marked as a duplicate of bug 480742 *** |
Created attachment 332927 [details] PATCH: Fix tk applications crashing with libX11-1.2 update tk applications started segfaulting after the libX11-1.2 update, atleast gitk is segfaulting for me. This is caused by tk not checking if a XCreateIC call succeeds. The attached patch fixed this by adding the check. This is safe todo as all other users already check if winPtr->inputContext is NULL. I've done some tracing with both libX11-1.1.99.2-4.fc11 and libX11-1.2-1.fc11, and with the former one the code path calling XCreateIC never got entered with the newer libX11 it does get entered but XCreateIC fails. This may be something worth investigating further, but given that with the older libX11 the XCreateIC calls was never made at all, I do not believe that this call failing will lead to regressions.