Bug 487007

This is an unofficial review:

- md5sum verification: Match the upstream tarball 
825464302989bb1dddf0badf114b4b94  /usr/src/redhat/SOURCES/stomper-0.2.2.tar.gz

- RPMLINT output. Please clarify the warnings below
# rpmlint -iv /usr/src/redhat/RPMS/noarch/python-stomp-0.2.2-2.fc9.noarch.rpm 
python-stomp.noarch: I: checking
python-stomp.noarch: W: hidden-file-or-dir /usr/share/doc/python-stomp-0.2.2/tests/.___init__.py
The file or directory is hidden. You should see if this is normal,
and delete it from the package if not.

python-stomp.noarch: W: hidden-file-or-dir /usr/share/doc/python-stomp-0.2.2/examples/._stomper_usage.py
The file or directory is hidden. You should see if this is normal,
and delete it from the package if not.

python-stomp.noarch: W: hidden-file-or-dir /usr/share/doc/python-stomp-0.2.2/doc/.___init__.py
The file or directory is hidden. You should see if this is normal,
and delete it from the package if not.

python-stomp.noarch: W: hidden-file-or-dir /usr/share/doc/python-stomp-0.2.2/examples/.___init__.py
The file or directory is hidden. You should see if this is normal,
and delete it from the package if not.

Thanks Suravee Suthikulpanit, I appreciate your review.

md5 verification:

[silas@pluto ~]$ curl --silent http://stomper.googlecode.com/files/stomper-0.2.2.tar.gz | md5sum
825464302989bb1dddf0badf114b4b94  -

RPMLINT output:

I manually removed the hidden OS X files and submitted a ticket upstream.

New SRPM: http://silassewell.googlecode.com/files/python-stomp-0.2.2-3.src.rpm

diff: http://code.google.com/p/silassewell/source/diff?spec=svn173&r=173&format=side&path=/trunk/projects/packages/rpms/python-stomp/python-stomp.spec

Upstream report: http://code.google.com/p/stomper/issues/detail?id=8

Hi There,

I'm stomper's author. I didn't realise these file were there when I generated the tar gzip on my laptop. Its strange as they only seem to appear inside the tar gzip. I guess I should just generate the tgz on linux instead of the mac ;)

I've replaced the tar gzip with one I generated on linux and verified that it does
not contain the mac specific ._* files.

All the best,

Oisin

Thanks Oisin!

The latest SRPM build and SPEC file diff.

SRPM: http://silassewell.googlecode.com/files/python-stomp-0.2.2-4.src.rpm
SPEC diff: http://code.google.com/p/silassewell/source/diff?spec=svn188&r=188&format=side&path=/trunk/projects/packages/rpms/python-stomp/python-stomp.spec

* Updated name to better conform to Fedora naming standard
* Changed define to global
 - https://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define
 - https://bugzilla.redhat.com/show_bug.cgi?id=490028#c1

SRPM: http://silassewell.googlecode.com/files/python-stomper-0.2.2-5.fc10.src.rpm

SPEC: http://silassewell.googlecode.com/svn/trunk/projects/packages/rpms/python-stomper/python-stomper.spec

Diff: http://code.google.com/p/silassewell/source/diff?spec=svn207&r=207&format=side&path=/trunk/projects/packages/rpms/python-stomper/python-stomper.spec

* Fixed dependencies

SRPM: http://silassewell.googlecode.com/files/python-stomper-0.2.2-6.fc10.src.rpm

Diff: http://code.google.com/p/silassewell/source/diff?spec=svn216&r=216&format=side&path=/trunk/projects/packages/rpms/python-stomper/python-stomper.spec

rpmlint

$ rpmlint python-stomper-0.2.2-6.fc10.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings
$ rpmlint python-stomper-0.2.2-6.fc10.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Notes:

* Requires
----------------------------------------------
Requires:       python(abi) >= 2.5
----------------------------------------------
  - is not needed. rpmbuild adds python abi related dependency
    automatically (on rawhide it is "python(abi) = 2.6"

Other things are okay.

----------------------------------------------------------
    This package (python-stomper) is APPROVED by mtasaka
----------------------------------------------------------

Final build with last fix.

SRPM: http://silassewell.googlecode.com/files/python-stomper-0.2.2-7.fc10.src.rpm

Diff: http://code.google.com/p/silassewell/source/diff?spec=svn221&r=221&format=side&path=/trunk/projects/packages/rpms/python-stomper/python-stomper.spec

rpmlint

[silas@silas ~]$ rpmlint python-stomper-0.2.2-7.fc10.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[silas@silas ~]$ rpmlint python-stomper-0.2.2-7.fc10.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

New Package CVS Request
=======================
Package Name: python-stomper
Short Description: A Python client implementation of the STOMP protocol
Owners: silas
Branches: 
InitialCC:

cvs done.

Built for F-11, closing.

Thanks Mamoru and Kevin.

python-stomper-0.2.2-8.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/python-stomper-0.2.2-8.el5

python-stomper-0.2.2-8.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/python-stomper-0.2.2-8.el5

python-stomper-0.2.2-8.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.