Bug 487031

Summary:	Remove producer throttling
Product:	Red Hat Enterprise MRG	Reporter:	Gordon Sim <gsim>
Component:	qpid-cpp	Assignee:	Ken Giusti <kgiusti>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Frantisek Reznicek <freznice>
Severity:	high	Docs Contact:
Priority:	high
Version:	1.1	CC:	esammons, jross
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	qpid-0.18	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-02-25 23:33:31 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Gordon Sim 2009-02-23 18:44:48 UTC

Flow control commands are sent out through broker::SessionState on a timer thread. If this happens concurrently with e.g. dispatch of message for a subscriber on that session, or when writing out the response/completion for a command other than transfer, there could be corruption of the output stream or other problems as all output is currently assumed to be done serially on the io thread.

Comment 1 Andrew Stitcher 2009-02-25 16:24:01 UTC

This isn't testable except by finding a soak test that fails oddly

Comment 2 Justin Ross 2011-06-28 18:20:11 UTC

Gordon, can this be closed?

Comment 3 Gordon Sim 2011-06-28 18:41:40 UTC

It certainly looks like the code was changed.

I think the best thing would be to remove the feature entirely. I don't believe anyone uses it and I don't think it is actually useful. I also don't believe there are any tests for it and I suspect QE don't test it either.

Comment 4 Justin Ross 2011-06-29 18:57:19 UTC

Turning this into a request to remove the producer throttling feature.  It's not currently in use, and it has no tests.

Comment 5 Justin Ross 2011-11-09 22:22:49 UTC

Ken, is the old producer-throttling now removed?

Comment 6 Ken Giusti 2011-11-14 19:25:30 UTC

No it hasn't been.  I've opened an upstream JIRA to issue a warning should that feature be used:

https://issues.apache.org/jira/browse/QPID-3615

Probably the polite thing to do for 0.14, then rip it out entirely in 0.15 (?)

Comment 7 Justin Ross 2011-11-14 19:31:04 UTC

Thanks. I think that's the right plan.

Comment 8 Ken Giusti 2012-01-13 19:01:02 UTC

Removed this from upstream in 0.15 development branch.

http://svn.apache.org/viewvc?view=rev&rev=1231221
http://svn.apache.org/viewvc?view=rev&rev=1231222