Bug 487791

I second the motion.

Reference: http://forums.fedoraforum.org/showthread.php?t=214669

Thanks,
VJS

Created attachment 334851 [details]
Spec file for knemo-0.5.1 rpm

If you would like this treated as a package review, please follow the instructions at http://fedoraproject.org/wiki/PackageMaintainers/Join

Spec URL: http://nucleo.fedorapeople.org/pkg-reviews/knemo/knemo.spec
SRPM URL: http://nucleo.fedorapeople.org/pkg-reviews/knemo/knemo-0.5.1-4.fc10.src.rpm

Description: KDE4 network monitoring tool

A few quick notes

in the %install and %clean sections replace

rm -rf %{buildroot}

with

rm -rf $RPM_BUILD_ROOT

as it is the more prefered way of doing things


also

make install DESTDIR=%{buildroot} -C %{_target_platform}

should be

make install DESTDIR=${RPM_BUILD_ROOT} -C %{_target_platform}

and

desktop-file-install --vendor "" \
    --dir %{buildroot}%{_datadir}/applications/kde4 \
    --remove-key=Path \
    %{buildroot}%{_datadir}/applications/kde4/%{name}.desktop

should be

desktop-file-install --vendor "" \
    --dir $RPM_BUILD_ROOT%{_datadir}/applications/kde4 \
    --remove-key=Path \
    $RPM_BUILD_ROOT%{_datadir}/applications/kde4/%{name}.desktop


This just helps keep all packages consistent

Steven

(In reply to comment #5)

you can use one %{buildroot} or other $RPM_BUILD_ROOT style

please look

https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS

all styles will be accepted,

(In reply to comment #5)
Steven, there is absolutely no need to use ${RPM_BUILD_ROOT} instead of %{buildroot}. The only requirement ( enforced by fedora, and not for a technical but for a mere cosmetic reason ) is to use only one set of macros in all the spec. nucleo does that, so there is absolutely no problem from this point of view.
See https://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS for details.


What could be changed is  '--vendor ""' which is not needed in fedora (but IS required if the same spec is to be used for RHEL - the older desktop-file-install barfs if there exists no vendor field)

Yes I know either is valid, however our KDE packages use $RPM_BUILD_ROOT so was just trying to keep things consistent among our packages, just as I said in my previous comment.

Steven

Just installed this for testing on my system and got the following

kdeinit4: preparing to launch /usr/bin/kbuildsycoca4
No protocol specified
kbuildsycoca4 running...
kbuildsycoca4(18327)/kdecore (KService) KServicePrivate::init: The desktop entry file  "/usr/share/applications/kde/koffice.desktop"  has Type= "Application" but no Exec line

kbuildsycoca4(18327)/kdecore (KService) KBuildServiceFactory::createEntry: Invalid Service :  "/usr/share/applications/kde/koffice.desktop"

Updated knemo.spec on the same links as in comment #4


(In reply to comment #9)
> Just installed this for testing on my system and got the following
> 
> kdeinit4: preparing to launch /usr/bin/kbuildsycoca4
> No protocol specified
> kbuildsycoca4 running...
> kbuildsycoca4(18327)/kdecore (KService) KServicePrivate::init: The desktop
> entry file  "/usr/share/applications/kde/koffice.desktop"  has Type=
> "Application" but no Exec line
> 
> kbuildsycoca4(18327)/kdecore (KService) KBuildServiceFactory::createEntry:
> Invalid Service :  "/usr/share/applications/kde/koffice.desktop"  

Is knemo leads to this?

It happened when I installed knemo, but looks like a koffice issue.  Sorry

(In reply to comment #0)

Do you have plans's to maintain it for F-10 ?

Do you have more packages to submit for review ?

I will take a look in your changes tonight.

(In reply to comment #12)
> Do you have plans's to maintain it for F-10 ?

I will try to maintain knemo in F-10. It my first package.
 
> Do you have more packages to submit for review ?

Yes I have some packages for example emulators dynamips, dynagen and GNS3 but they are should be improved.

nucleo once you are ready for an official package review please follow the instructions noted in comment https://bugzilla.redhat.com/show_bug.cgi?id=487791#c3

(In reply to comment #14)
> nucleo once you are ready for an official package review please follow the
> instructions noted in comment
> https://bugzilla.redhat.com/show_bug.cgi?id=487791#c3  

him already have a sponsored fedora account.

what you think about grabbing it in pkgdb ?

https://admin.fedoraproject.org/pkgdb/packages/name/knemo

it' doesn't need to be reviewed again

we need only to discover the initial review request and ask for F-10 cvs branch

(In reply to comment #15)
> (In reply to comment #14)
> > nucleo once you are ready for an official package review please follow the
> > instructions noted in comment
> > https://bugzilla.redhat.com/show_bug.cgi?id=487791#c3  
> 
> him already have a sponsored fedora account.
> 
> what you think about grabbing it in pkgdb ?
> 
> https://admin.fedoraproject.org/pkgdb/packages/name/knemo
> 
> it' doesn't need to be reviewed again
> 
> we need only to discover the initial review request and ask for F-10 cvs branch  

As this is a KDE package and the nucleo is a new contributor, ie: it is his 1st package I was asked to take a look at this and help with reviewing this.  Your sarcasm and comments are not required or welcome.

And as noted in https://fedoraproject.org/wiki/Orphaned_package_that_need_new_maintainers

Old becomes new
If a package was last updated more than three months ago (running cvs log -r HEAD *.spec can show you this information), you will need to submit a review request and have the package approved by a reviewer as if it were new to Fedora. See the package review process for more information.

(In reply to comment #14)
I follow instructions from comment #3 link.

I create bugzilla account, join to fedora-devel-announce,
make and upload knemo package, change component in bz#487791 to Package Review,
get fedora account, perform successful scratch build of knemo
http://koji.fedoraproject.org/koji/taskinfo?taskID=1244882
and wait when package will be APPROVED.

What I should do now?

(In reply to comment #4)
> Spec URL: http://nucleo.fedorapeople.org/pkg-reviews/knemo/knemo.spec
> SRPM URL:
> http://nucleo.fedorapeople.org/pkg-reviews/knemo/knemo-0.5.1-4.fc10.src.rpm
> 
> Description: KDE4 network monitoring tool  

For info: knemo-0.5.1-4.fc10.src.rpm rebuilt on F10
2.6.27.19-170.2.35.fc10.i686; no errors nor warnings of any kind noted; updated
(from knemo-0.5.1-1.fc10.i386) OK; "Statistics" and "Traffic Plotter" window
positions and sizes preserved intact. :-)

Looks good here. Thanks, nucleo....

Regards,
VJS

Nucleo,  package is APPROVED for re-inclusion in Fedora F10+.  Please follow the guidelines at https://fedoraproject.org/wiki/CVS_admin_requests for requesting an F10 branch be added to CVS.  You will also need to ask itamarjp to release ownership of the devel branch.

Since there's interest, I'd suggest both nucleo and itamarjp comaintain this together (more the merrier!).  Is that agreeable to each of you?

In the meantime, as nucleo's sponsor, I'll add myself to be CC'd here, so I can watch, guide, mentor, and all that good sponsor-type stuff.

and a reminder, make sure to include F-10 branch in the cvsadmin request (per comment #19), and please CC: me (rdieter) in said request.  thanks.

(In reply to comment #20)
Rdieter , thanks for your help.
Initially last maintainer of knemo was faucamp when I create #487791.

In comment #12 itamarjp asked me about maintaining.
So as I want to try to maintain knemo I ask itamarjp
to release ownership of the devel branch.

New Package CVS Request
=======================
Package Name: knemo
Short Description: KDE4 network monitoring tool
Owners: nucleo
Branches: F-10
InitialCC: rdieter

It's not a new package, please add only missing F-10 branch.


Package Change Request
======================
Package Name: knemo
New Branches:  F-10
Owners: nucleo rdieter itamarjp

cvs done.

(In reply to comment #24)
So I can't commit any changes to the devel branch?
cvs commit...
**** Access denied: nucleo is not in ACL for rpms/knemo/devel

(In reply to comment #25)
When I run make build for F-10 I get:
FAILED: BuildError: package knemo is blocked for tag dist-f10-updates-candidate
http://koji.fedoraproject.org/koji/taskinfo?taskID=1245742

Nucleo, you need to go to https://admin.fedoraproject.org/pkgdb/packages/name/knemo   login with your fas username and request the ACLs for the F9 and devel branches.  You want to request all 4 as the commaintainer.

(In reply to comment #26)
(In reply to comment #27)


please hold, the ACLS are ok, but the package for F-10 is locked unlock requested at -> 

https://fedorahosted.org/rel-eng/ticket/1386

ticket 1386 closed as fixed in rel-eng, please try to build again within 1 hour and if not work post a message

it's possible to build for devel and F-9 too ?

(In reply to comment #27)
Thanks. I request the ACLs for the F9 and devel branches.

(In reply to comment #29)
Builds for F-10 and devel are successful 
http://koji.fedoraproject.org/koji/taskinfo?taskID=1245912
http://koji.fedoraproject.org/koji/taskinfo?taskID=1245962

But build for F-9 with error:
BuildError: package knemo is blocked for tag dist-f9-updates-candidate
http://koji.fedoraproject.org/koji/taskinfo?taskID=1245980

(In reply to comment #30)
I have problem with devel build,
http://koji.fedoraproject.org/koji/taskinfo?taskID=1245962
this build without my commit.
With commit I have problem when I run make tag:
cvs tag: Pre-tag check failed
cvs [tag aborted]: correct the above errors first!
make: *** [tag] Error 1

(In reply to comment #29)
Thanks.
Now all builds for F-9, F-10 and devel are completed successfully.
http://koji.fedoraproject.org/koji/taskinfo?taskID=1246036
http://koji.fedoraproject.org/koji/taskinfo?taskID=1246075
http://koji.fedoraproject.org/koji/taskinfo?taskID=1246089

knemo-0.5.1-4.fc10.1 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/knemo-0.5.1-4.fc10.1

knemo-0.5.1-4.fc9.1 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/knemo-0.5.1-4.fc9.1

knemo-0.5.1-5.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/knemo-0.5.1-5.fc10

knemo-0.5.1-5.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/knemo-0.5.1-5.fc9

knemo-0.5.1-5.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

knemo-0.5.1-5.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Package Change Request
======================
Package Name: knemo
New Branches:  F-11
Owners: nucleo rdieter itamarjp

F-11 branch is the current devel

after F-11 released the devel branch automatically becomes F-11

no need to ask for F-11 branch

(In reply to comment #40)
> F-11 branch is the current devel
> 
> after F-11 released the devel branch automatically becomes F-11
> 
> no need to ask for F-11 branch  

Thank you.
I wrongly understood Jesse Keating mail
https://www.redhat.com/archives/fedora-devel-announce/2009-March/msg00021.html

Package Change Request
======================
Package Name: knemo
New Branches: el6
Owners: nucleo

Git done (by process-git-requests).