Bug 487839

Summary:	Review Request: perl-Catalyst-Plugin-Email - Send emails with Catalyst
Product:	[Fedora] Fedora	Reporter:	Iain Arnell <iarnell>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, panemade
Target Milestone:	---	Flags:	panemade: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	0.08-1.fc9	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-03-01 04:47:24 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Iain Arnell 2009-02-28 05:37:13 UTC

Spec URL: http://iarnell.fedorapeople.org/rpms/perl-Catalyst-Plugin-Email.spec
SRPM URL: http://iarnell.fedorapeople.org/rpms/perl-Catalyst-Plugin-Email-0.08-1.fc11.src.rpm
Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1207949
Description: Send emails with Catalyst and Email::Send and Email::MIME::Creator.

Comment 1 Parag AN(पराग) 2009-02-28 06:22:11 UTC

Review:
+ package builds in mock (rawhide i386).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1207949
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
173e2b91b21e55da9671220734869c6d  Catalyst-Plugin-Email-0.08.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is NOT present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
All tests successful.
Files=3, Tests=1,  1 wallclock secs ( 0.01 usr  0.00 sys +  0.11 cusr  0.02 csys =  0.14 CPU)
+ Package perl-Catalyst-Plugin-Email-0.08-1.fc11-noarch =>
  Provides: perl(Catalyst::Plugin::Email) = 0.08
  Requires: perl(Carp) perl(Email::MIME) perl(Email::MIME::Creator) perl(Email::Send) perl(strict)

 APPROVED.

Comment 2 Iain Arnell 2009-02-28 06:31:31 UTC

New Package CVS Request
=======================
Package Name: perl-Catalyst-Plugin-Email
Short Description: Send emails with Catalyst
Owners: iarnell
Branches: F-9 F-10
InitialCC: perl-sig

Comment 3 Kevin Fenzi 2009-02-28 23:48:11 UTC

cvs done.

Comment 4 Fedora Update System 2009-03-01 04:46:05 UTC

perl-Catalyst-Plugin-Email-0.08-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/perl-Catalyst-Plugin-Email-0.08-1.fc10

Comment 5 Fedora Update System 2009-03-01 04:46:12 UTC

perl-Catalyst-Plugin-Email-0.08-1.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/perl-Catalyst-Plugin-Email-0.08-1.fc9

Comment 6 Fedora Update System 2009-03-18 19:09:43 UTC

perl-Catalyst-Plugin-Email-0.08-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2009-03-18 19:11:38 UTC

perl-Catalyst-Plugin-Email-0.08-1.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.