Bug 487901
| Summary: | Review Request: zikula - web-based CMS | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David Nalley <david> |
| Component: | Package Review | Assignee: | Clint Savage <herlo1> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, herlo1, luhe, notting, pahan |
| Target Milestone: | --- | Flags: | herlo1:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.1.1-12.fc9 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-03-23 15:53:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
David Nalley
2009-03-01 04:26:40 UTC
Herlo pointed out an SElinux problem with /etc/zikula/config.php I fixed this. Spec URL: http://ke4qqq.fedorapeople.org/zikula.spec SRPM URL: http://ke4qqq.fedorapeople.org/zikula-1.1.1-7.fc10.src.rpm Yet another SELinux problem pointed about by herlo Spec URL: http://ke4qqq.fedorapeople.org/zikula.spec SRPM URL: http://ke4qqq.fedorapeople.org/zikula-1.1.1-8.fc10.src.rpm Reviewing http://ke4qqq.fedorapeople.org/zikula-1.1.1-7.fc10.src.rpm Couple odd things after installed successfully, probably for upstream: - The accept licence page has no content. - The selinux context of the zikula/config.php is incorrect, should be system_u:object_r:httpd_var_run_t:s0. Similar to what you did for the /etc/zikula directory - Upon login to the administration section, the following errors appear * Stop, please! Installer file 'install.php' and directory 'install' are in the site root, but must be removed before you can access the Admin Panel. * Stop, please! An upgrade script (file 'upgrade.php') is in the site root, but must be removed before you can access the Admin Panel. * Stop, please! An upgrade script (file 'upgrade10xto11x.php') is in the site root, but must be removed before you can access the Admin Panel. This could be fixed upstream by doing a little work to the install.php script. It could eliminate this unnecessary validation if it just removed/moved/chmod'd the dirs themselves. Finally, zikula insists the config.php be writable during the install process, but once the install is completed, the admin section complains that it is writable. Again, the install process could make these changes simply. Clint Reviwing http://ke4qqq.fedorapeople.org/zikula-1.1.1-8.fc10.src.rpm $ rpmlint SPECS/zikula.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint SRPMS/zikula-1.1.1-8.fc10.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. No rpmlint errors. Quite a change from a few versions ago. The SELinux error on config.php still exists, consider using semanage instead of just changing the context. semanage makes the contexts stick. Clint so rpm doesn't honor xattr as I learned, I reverted earlier selinux changes and used semanage in a %post section to define a context for config.php and then restorecon Spec URL: http://ke4qqq.fedorapeople.org/zikula.spec SRPM URL: http://ke4qqq.fedorapeople.org/zikula-1.1.1-9.fc10.src.rpm I'm pretty happy with the results in the latest rpm/spec you provided. rpmlint is clean. However, might I suggest you put the selinux changes into a %pre section? It makes complete sense as the selinux context and parameter should be set prior to adding files which will get the context. That's the last gripe I have. Otherwise, everything works from install to activation with a database. Cheers, Clint Done Please find: Spec URL: http://ke4qqq.fedorapeople.org/zikula.spec SRPM URL: http://ke4qqq.fedorapeople.org/zikula-1.1.1-10.fc10.src.rpm The semanage stuff in %pre had some problems and wouldn't always exit 0. Please find : Spec URL: http://ke4qqq.fedorapeople.org/zikula.spec SRPM URL: http://ke4qqq.fedorapeople.org/zikula-1.1.1-12.fc10.src.rpm This appears to work well now. I'm putting my stamp of approval on the package and sending it on. Clint New Package CVS Request ======================= Package Name: zikula Short Description: web-based CMS Owners: ke4qqq Branches: F-9 F-10 EL5 InitialCC: You may want to ping dwalsh and just get the selinux changes you need made to the policy. cvs done. zikula-1.1.1-12.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/zikula-1.1.1-12.fc9 zikula-1.1.1-12.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/zikula-1.1.1-12.fc10 zikula-1.1.1-12.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. zikula-1.1.1-12.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |