Bug 488105

Summary:	Review Request: rubygem-htmlentities - A module for encoding and decoding (X)HTML entities
Product:	[Fedora] Fedora	Reporter:	Mamoru TASAKA <mtasaka>
Component:	Package Review	Assignee:	Orcan Ogetbil <oget.fedora>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, oget.fedora
Target Milestone:	---	Flags:	oget.fedora: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-03-06 07:27:44 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Mamoru TASAKA 2009-03-02 18:06:05 UTC

Spec URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-htmlentities/rubygem-htmlentities.spec
SRPM URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-htmlentities/rubygem-htmlentities-4.0.0-1.fc.src.rpm
koji scratch build:
- for dist-f11: http://koji.fedoraproject.org/koji/taskinfo?taskID=1213998
- for dist-f10: http://koji.fedoraproject.org/koji/taskinfo?taskID=1213999
Description: 
HTMLEntities is a simple library to facilitate encoding and 
decoding of named (&yacute; and so on) or numerical (&#123; or &#x12a;) 
entities in HTML and XHTML documents.

Comment 1 Orcan Ogetbil 2009-03-04 00:57:24 UTC

This is a very simple ruby package. I went through it and didn't find any problems. But I have a few questions and two little suggestions:

? The other rubygem packages have BR: ruby(rubygems). This one has BR: rubygems. Why is there a difference? Does it matter? Also BR: ruby(abi) = %{rubyabi} will be pulled up by BR: rubygems. Do we really need to specify it specifically? I know the guidelines tell us to do so. But I don't know why.

! The ruby guidelines tell us to use %global instead of %define. While it doesn't matter much in this case, it would be good to obey the guidelines.

! It would look nicer and consistent if you make the description span evenly and use the full 80 columns.


Otherwise, the package is good to go:

-------------------------------------------------------
This package (rubygem-htmlentities) is APPROVED by oget
-------------------------------------------------------

Comment 2 Mamoru TASAKA 2009-03-04 10:07:31 UTC

Thank you for a quick review!
(In reply to comment #1)

> ? The other rubygem packages have BR: ruby(rubygems). This one has BR:
> rubygems. Why is there a difference? Does it matter? 
- No deference, however I prefer to use ruby(rubygems) so I will
  switch to ruby(rubugems)

> Also BR: ruby(abi) =
> %{rubyabi} will be pulled up by BR: rubygems. Do we really need to specify it
> specifically? I know the guidelines tell us to do so.
- I usually add this abi dependency for BR explicitly to make it
  consistent with Requires of ruby abi dependency.

> ! The ruby guidelines tell us to use %global instead of %define. While it
> doesn't matter much in this case, it would be good to obey the guidelines.
- Will change.

-----------------------------------------------------
New Package CVS Request
=======================
Package Name:          rubygem-htmlentities
Short Description:     A module for encoding and decoding (X)HTML entities
Owners:                mtasaka
Branches:              F-10 F-9 
InitialCC:             (nobody)

Comment 3 Kevin Fenzi 2009-03-05 20:26:47 UTC

cvs done.

Comment 4 Mamoru TASAKA 2009-03-06 07:27:44 UTC

Rebuilt on all branches, submitted push requests for F-10/9, closing.
Thank you for your review and CVS procedure.